Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finalcut: init at 0.9.1 #371143

Merged
merged 1 commit into from
Jan 13, 2025
Merged

finalcut: init at 0.9.1 #371143

merged 1 commit into from
Jan 13, 2025
+38 −0

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 5, 2025 •
edited
Loading

finalcut - the modern text-based widget toolkit.

Packaging status

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

momeemt
momeemt suggested changes Jan 5, 2025
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. finalcut seems to be licensed LGPL v3 only.

pkgs/by-name/fi/finalcut/package.nix Show resolved Hide resolved
@sikmir sikmir requested a review from momeemt January 5, 2025 15:43
@momeemt momeemt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 5, 2025
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371143

aarch64-darwin

✅ 1 package built:
  • finalcut

@sikmir sikmir requested a review from FliegendeWurst January 13, 2025 18:14
@FliegendeWurst FliegendeWurst merged commit 0b2095f into NixOS:master Jan 13, 2025
24 of 27 checks passed
@sikmir sikmir deleted the finalcut branch January 14, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momeemt momeemt momeemt approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sikmir @ethancedwards8 @FliegendeWurst @momeemt