rattler-build: 0.33.1 -> 0.34.1 #373448
Merged
rattler-build: 0.33.1 -> 0.34.1 #373448
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiangmoe
force-pushed
the
rattler-build
branch
from
e51693c to
a2db10b
Compare
|
First of all kindly ensure there is one commit, there is no need for the |
xiaoxiangmoe
force-pushed
the
rattler-build
branch
from
a2db10b to
8577150
Compare
genga898
reviewed
Jan 13, 2025
|
|
||
| doInstallCheck = true; | ||
| postInstall = lib.optionalString (stdenv.hostPlatform.emulatorAvailable buildPackages) ( |
There was a problem hiding this comment.
postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) ''
# using named fd
installShellCompletion --cmd foobar \
--bash <($out/bin/foobar --bash-completion) \
--fish <($out/bin/foobar --fish-completion) \
--zsh <($out/bin/foobar --zsh-completion)
'';Won't this look like a cleaner way of installing shell completions, according to the docs
There was a problem hiding this comment.
No, this is a legacy doc which is outdated for not supporting cross platform build. We need to use stdenv.hostPlatform.emulatorAvailable instead.
There was a problem hiding this comment.
I haven't dealt with shell completions much so maybe I'll ask someone else, any reference to the new docs?
genga898
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.