rerun: support web_viewer feature #373461
Open
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierLDff
force-pushed
the
rerun-support-web-viewer
branch
from
0532cc4 to
6fdc1da
Compare
When web_viewer is compiled, the wasm webviewer first needs to be built If this doesn't exist, the build will fail. More information: rerun-io/rerun#6028 The command is taken from https://github.com/rerun-io/rerun/blob/dd025f1384f9944d785d0fb75ca4ca1cd1792f17/pixi.toml#L198C72-L198C187 Note that cargoBuildFeatures reference what buildFeatures is set to in stdenv.mkDerivation, so that user can easily create an overlay to set cargoBuildFeatures to what he needs
OlivierLDff
force-pushed
the
rerun-support-web-viewer
branch
from
6fdc1da to
1e9aeb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When web_viewer is compiled, the wasm webviewer first needs to be built
If this doesn't exist, the build will fail. More information: rerun-io/rerun#6028
The command is taken from https://github.com/rerun-io/rerun/blob/dd025f1384f9944d785d0fb75ca4ca1cd1792f17/pixi.toml#L198C72-L198C187
Note that cargoBuildFeatures reference what buildFeatures is set to in stdenv.mkDerivation,
so that user can easily create an overlay to set cargoBuildFeatures to what he needs