Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruffle-bin: init at 2025-01-13 (#285887) #373520

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

normalcea
Copy link

@normalcea normalcea commented Jan 13, 2025

Depends on #371012 and is a proof of concept draft for adding a binary ruffle package to nixpkgs. This fixes issue #285887 as it doesn't build deterministically as well as adding support for ruffle's about page[1, prebuilt is left, native comp is right]. It also allows for automatic updating with nix-update-script --version=unstable without burdening CI.

A pre-built binary package also allows for easily pinning a version of ruffle without the burden of having to compile ruffle from source on the user's end which is very time/resource consuming as it is a complex Rust project.

I do not have access to a Darwin machine so I left the derivation for darwin as a stub. @jchv if you can fill that in that would be great. Anyone with a Linux machine can also help test (for example, on a X11 display server vs. wayland).

[1]
comparison

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@normalcea normalcea marked this pull request as draft January 13, 2025 18:32
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant