Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/public-inbox: fix test by creating Gitolite repositories #373522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/public-inbox: fix test by creating Gitolite repositories #373522

wants to merge 1 commit into from
+21 −25

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Jan 13, 2025 •
edited
Loading

Previously in #308740 BindReadOnlyPaths= was fixed, but remained mounting non-existing Git repositories:

vm-test-run-public-inbox> machine # [ 19.503051] (ox-httpd)[1489]:
public-inbox-httpd.service: Failed to set up mount namespacing:
/var/lib/gitolite/repositories/user/repo1.git: No such file or directory

Things done

  • Create Git repositories (without using gitolite anymore).
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Ping @alyssais

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 13, 2025
@ju1m
Copy link
Contributor Author

ju1m commented Jan 13, 2025

Hmm, why is OfBorg skipping the test ? https://github.com/NixOS/nixpkgs/pull/373522/checks?check_run_id=35548340273

OfBorg / nixos/public-inbox, nixos/public-inbox.passthru.tests on x86_64-linux skipped Jan 13, 2025 in 0s
No attempt

The following builds were skipped because they don't evaluate on x86_64-linux: nixos/public-inbox, nixos/public-inbox.passthru.tests

Details
Partial log

Cannot nix-instantiate `nixos/public-inbox` because:
error: attribute 'nixos/public-inbox' in selection path 'nixos/public-inbox' not found

Cannot nix-instantiate `nixos/public-inbox.passthru.tests` because:
error: attribute 'nixos/public-inbox' in selection path 'nixos/public-inbox.passthru.tests' not found

@alyssais
Copy link
Member

OfBorg parses attribute paths from commit messages, and "nixos/public-inbox" isn't one of them. (nixosTests.public-inbox would be though.)

@ofborg test public-inbox

alyssais
alyssais approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if it would be simpler to just use bare git repos that we could git init than using gitolite at all in this test, but if this makes it work again it's fine.

@ju1m
nixos/public-inbox: fix test by creating Git repositories
f5a78d3 
Previously in NixOS#308740
`BindReadOnlyPaths=` was fixed, but remained mounting non-existing Git repositories:

vm-test-run-public-inbox> machine # [   19.503051] (ox-httpd)[1489]:
public-inbox-httpd.service: Failed to set up mount namespacing:
/var/lib/gitolite/repositories/user/repo1.git: No such file or directory
@ju1m ju1m force-pushed the public-inbox-fix branch from 59f7c97 to f5a78d3 Compare January 14, 2025 10:29
@ju1m
Copy link
Contributor Author

ju1m commented Jan 14, 2025

OfBorg parses attribute paths from commit messages, and "nixos/public-inbox" isn't one of them. (nixosTests.public-inbox would be though.)

@alyssais Should I rather use nixosTests.public-inbox as a prefix of the commit message then?

@ju1m
Copy link
Contributor Author

ju1m commented Jan 14, 2025 •
edited
Loading

@ofborg test public-inbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ju1m @alyssais