Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/request-reviews: request codeowners from parent folders #373527

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ci/request-reviews: request codeowners from parent folders #373527

wants to merge 2 commits into from
+65 −57

Conversation

wolfgangwalther
Copy link
Contributor

As discussed in #360286 (review).

To check codeowners for the codeowners-v2.yml workflow file, run this:

ci/request-reviews/get-code-owners.sh . ci/OWNERS 973017d9{~1,}

Before this PR:

This PR touches 1 files
File .github/workflows/codeowners-v2.yml is owned by @infinisil
infinisil

After:

This PR touches 1 files
Path .github/workflows/codeowners-v2.yml is owned by @infinisil
Path .github/workflows is owned by @NixOS/Security @Mic92 @zowoq @infinisil @azuwis
Team NixOS/Security has these members: mweinelt LeSuisse risicle
Path .github is unowned
mic92
risicle
lesuisse
zowoq
mweinelt
azuwis
infinisil

Unfortunately, the codeowners binary only returns a single line, not the parent lines. Thus we resort to grepping the OWNERS file ourselves. Not pretty, but works.

Lots of whitespace noise, review with whitespace changes invisible.

Things done

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Jan 13, 2025
@wolfgangwalther
ci/request-reviews: request codeowners from parent folders
e5495a0 
Previously, with the following OWNERS file:

/a @x
/a/b @y

a change to /a/b would only ping @y. After this change, both @x and @y
are pinged.
@wolfgangwalther
ci/request-reviews: rename file to path
1a6abb1 
Now that we're traversing parent paths as well.
@wolfgangwalther wolfgangwalther force-pushed the ci-match-all-code-owners branch from fa9f8b7 to 1a6abb1 Compare January 13, 2025 19:21
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@philiptaron philiptaron Awaiting requested review from philiptaron

@risicle risicle Awaiting requested review from risicle

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wolfgangwalther