nixos/radicale: Allow AF_UNIX for systemd log #373893
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radicale tries to connect to the systemd unix socket for logging. This currently fails because it is not allowed to open sockets, then it falls back to logging to stdout (printing a warning). Allow radical to open unix sockets to fix this. This gives slightly better logging experience (e.g. errors are marked red when sent through the systemd log socket).
github-actions
bot
added
6.topic: nixos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radicale tries to connect to the systemd unix socket for logging. This currently fails because it is not allowed to open sockets, then it falls back to logging to stdout (printing a warning).
Allow radical to open unix sockets to fix this. This gives slightly better logging experience (e.g. errors are marked red when sent through the systemd log socket).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.