POC minifying bundles

src/Builder.hs

@@ -2,7 +2,7 @@ module Builder
   ( build
   ) where
 
-import CliArguments (Args(..))
+import CliArguments (Args(..), Minify(..))
 import qualified Compile
 import ConcatModule
 import Config
@@ -19,13 +19,15 @@ import qualified Data.Text.IO as TIO
 import qualified Data.Tree as Tree
 import qualified DependencyTree
 import qualified EntryPoints
+import GHC.IO.Handle
 import qualified Init
 import qualified Logger
 import qualified Message
 import ProgressBar (ProgressBar, complete, start, tick)
 import qualified System.Console.AsciiProgress as AsciiProgress
-import qualified System.Exit
+import System.Exit
 import System.FilePath ((<.>), (</>))
+import System.Process
 
 build :: Config.Config -> Args -> IO ()
 build config args = do
@@ -87,12 +89,28 @@ buildHelp config args = do
     do createdModulesJson pg config modules
        complete pg
        traverse (Compile.printTime args) result
+  _minified <- Concurrent.mapConcurrently (minfiyModule pg config args) modules
   -- RETURN WARNINGS IF ANY
   let warnings = Data.Maybe.catMaybes (fmap Compile.warnings result)
   case warnings of
     [] -> return $ Success entryPoints
     xs -> return $ Warnings entryPoints xs
 
+minfiyModule :: ProgressBar -> Config -> Args -> FilePath -> IO ()
+minfiyModule _pg Config {minifierPath} Args {minify} output = do
+  case minify of
+    DontMinify -> return ()
+    Minify -> do
+      (_, Just out, Just err, ph) <-
+        createProcess
+          (proc "bash" ["-c", minifierPath <> " " <> output])
+          {std_out = CreatePipe, std_err = CreatePipe}
+      _ec <- waitForProcess ph
+      content <- hGetContents out
+      print content
+      _errContent <- hGetContents err
+      pure ()
+
 createdModulesJson :: ProgressBar -> Config -> [FilePath] -> IO ()
 createdModulesJson pg config paths = do
   let encodedPaths = Aeson.encode paths

src/CliArguments.hs

@@ -3,6 +3,7 @@
 module CliArguments
   ( Args(..)
   , RunMode(..)
+  , Minify(..)
   , readArguments
   ) where
 
@@ -17,6 +18,7 @@ data Args = Args
   , warn :: Bool
   , time :: Bool
   , clean :: Bool
+  , minify :: Minify
   , runMode :: RunMode
   }
 
@@ -25,6 +27,10 @@ data RunMode
   | Watch
   | Version
 
+data Minify
+  = Minify
+  | DontMinify
+
 readArguments :: IO Args
 readArguments =
   execParser (info (parser <**> helper) $ fullDesc <> progDesc "🚀 📦")
@@ -48,6 +54,7 @@ parser = do
   clean <-
     switch
       (long "clean" <> short 'c' <> help "Cleans elm-stuff and removes .jetpack")
+  minify <- switch (long "minify" <> help "Minify the compiled js bundle.")
   return
     Args
     { entryPointGlob = entryPointGlob
@@ -62,6 +69,10 @@ parser = do
           else warn
     , time = time
     , clean = clean
+    , minify =
+        if minify
+          then Minify
+          else DontMinify
     , runMode =
         if version
           then Version

src/Config.hs

@@ -25,6 +25,7 @@ data Config = Config
   , outputDir :: FilePath
   , elmMakePath :: Maybe FilePath
   , coffeePath :: Maybe FilePath
+  , minifierPath :: FilePath
   , noParse :: [FilePath]
   , watchFileExt :: [T.Text]
   , watchIgnorePatterns :: [T.Text]
@@ -43,6 +44,7 @@ instance Aeson.FromJSON Config where
     v .: "output_js_directory" <*>
     v .:? "elm_make_path" <*>
     v .:? "coffee_path" <*>
+    v .: "minifier_path" <*>
     v .:? "no_parse" .!= [] <*>
     v .:? "watch_file_extensions" .!= [".elm", ".coffee", ".js", ".json"] <*>
     v .:? "watch_file_ignore_patterns" .!= ["/[.]#[^/]*$", "/~[^/]*$"]

test/ConfigSpec.hs

@@ -22,6 +22,7 @@ suite =
            , outputDir = "app" </> "js"
            , elmMakePath = Nothing
            , coffeePath = Nothing
+           , minifierPath = "uglify"
            , noParse =
                ["." </> "node_modules" </> "clipboard" </> "clipboard.js"]
            , watchFileExt = [".elm", ".coffee", ".js", ".json"]

test/fixtures/jetpack.json

@@ -6,6 +6,7 @@
   "temp_directory" : "app/tmp",
   "log_directory" : "app/logs",
   "output_js_directory" : "app/js",
+  "minifier_path" : "uglify",
   "no_parse": [
     "./node_modules/clipboard/clipboard.js"
   ]