Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify what to do for a question mark icon tooltip #1563

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

krinhorn
Copy link
Contributor

@krinhorn krinhorn commented Nov 3, 2023

Fixes A11-3770

Copy link

linear bot commented Nov 3, 2023

A11-3770 Clarify that we should use Tooltip.viewToggleTip for this case

Context

waj said in ZEN-1012:

ben.dansby the guide in the component catalog explicitly says that we could use the disclosure when:

  • the tooltip trigger isn't a "?" icon

https://noredink-ui.netlify.app/#/doodad/Tooltip

😕

A11ybats work

We could probably just change this bullet to say

  • the tooltip trigger isn't a "?" icon (use Tooltip.viewToggleTip for this case)

@krinhorn krinhorn changed the title clarify what to do for a question mark icon clarify what to do for a question mark icon tooltip Nov 3, 2023
@krinhorn krinhorn requested a review from charbelrami November 3, 2023 17:01
Copy link
Contributor

@charbelrami charbelrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@krinhorn krinhorn merged commit 099d8c3 into master Nov 6, 2023
5 checks passed
@krinhorn krinhorn deleted the bat/clarify-toggletip-usage branch November 6, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants