Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily writing assignment icons #1564

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

caseyWebb
Copy link
Member

@caseyWebb caseyWebb commented Nov 7, 2023

🔧 Modifying a component

Context

Adds daily writing (bell) assignment icon

🖼️ What does this change look like?

Screenshot 2023-11-07 at 12 43 54
Screenshot 2023-11-07 at 12 43 47

Component completion checklist

  • I've gone through the relevant sections of the Development Accessibility guide with the changes I made to this component in mind
  • Changes are clearly documented
    • Component docs include a changelog
    • Any new exposed functions or properties have docs
  • Changes extend to the Component Catalog
    • The Component Catalog is updated to use the newest version, if appropriate
    • The Component Catalog example version number is updated, if appropriate
    • Any new customizations are available from the Component Catalog
    • The component example still has:
      • an accurate preview
      • valid sample code
      • correct keyboard behavior
      • correct and comprehensive guidance around how to use the component
  • Changes to the component are tested/the new version of the component is tested
  • Component API follows standard patterns in noredink-ui
    • e.g., as a dev, I can conveniently add an nriDescription
    • and adding a new feature to the component will not require major API changes to the component
  • If this is a new major version of the component, our team has stories created to upgrade all instances of the old component. Here are links to the stories:
    • N/A, not a major version
  • Please assign the following reviewers (applicable Sep 2023–Dec 2023):
    • a11y-volunteer-reviewers - Someone from this group will review your PR in full.
    • team-accessibilibats-a11ybats - Someone from this group will review your PR for ACCESSIBILITY ONLY.
    • Someone from your team who can review requirements from your team's perspective. (This could be the same person from the a11y-volunteer-reviewers group if you'd like.)
    • If there are user-facing changes, a designer. (You may want to direct your designer to the deploy preview for easy review):
      • For writing-related component changes, add Stacey (staceyadams)
      • For quiz engine-related components, add Ravi (ravi-morbia)
      • For a11y-related changes to general components, add Ben (bendansby)
      • For general component-related changes or if you’re not sure about something, add the Design group (NoRedInk/design)

@caseyWebb caseyWebb requested review from bendansby, a team and bcardiff and removed request for a team November 7, 2023 18:45
Copy link

linear bot commented Nov 7, 2023

KRA-1225 Add bell icon to noredink-ui

  • Check with design for the right icon
  • Update breadcrumb definition

@caseyWebb caseyWebb requested review from a team and charbelrami and removed request for a team November 7, 2023 18:47
@bcardiff bcardiff merged commit 6bc3296 into master Nov 7, 2023
5 checks passed
@bcardiff bcardiff deleted the kra-1225-add-bell-icon-to-noredink-ui branch November 7, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants