Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump noredink-ui to 27.4.0 to include Block API ReadAloud #1570

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

micahhahn
Copy link
Member

@micahhahn micahhahn commented Nov 29, 2023

🏷️ Bump for version 27.4.0

What changes does this release include?

How has the API changed?

Please paste the output of elm diff run on latest master in the code block:

This is a MINOR change.

---- Nri.Ui.Block.V6 - MINOR ----

    Added:
        renderReadAloud :
            List.List (Nri.Ui.Block.V6.Attribute msg) -> String.String


Releasing

After this PR merges, and you've pulled down latest master, finish following the publishing process.

Copy link

linear bot commented Nov 29, 2023

PHX-1215 Improve readaloud for new Scaffolding Markdown in QuestionBox

[DESCRIPTION]

Acceptance Criteria

  • The readaloud button is aligned with the first line of the question box, even if the first line contains a label.
  • The text sent to readaloud properly handles display elements like blanks and does not readaloud emphasis, icons, etc.

@micahhahn micahhahn changed the title Bump noredink-ui to 27.4.0 Bump noredink-ui to 27.4.0 to include Block API ReadAloud Nov 29, 2023
@micahhahn micahhahn requested a review from juanedi November 29, 2023 15:21
@micahhahn micahhahn marked this pull request as ready for review November 29, 2023 15:22
@micahhahn micahhahn merged commit 4ae0c74 into master Nov 29, 2023
5 checks passed
@micahhahn micahhahn deleted the phx-1215-bump-noredink-ui-to-27.4.0 branch November 29, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants