Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Ensure there's room for the modal close X #1596

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

tesk9
Copy link
Contributor

@tesk9 tesk9 commented Jan 17, 2024

Context

Fixes A11-4004
Fixes A11-4012

The modal's close x currently sometimes partially obscures the modal's title on mobile.

This PR adjusts the modal title's padding on mobile when the x is present so that there's no overlap between the x and the title.

🖼️ What does this change look like?

Before After
Screenshot 2024-01-17 at 9 35 12 AM Screenshot 2024-01-17 at 9 34 52 AM

Here is the padding highlighted:
Screenshot 2024-01-17 at 9 35 21 AM

Component completion checklist

  • I've gone through the relevant sections of the Development Accessibility guide with the changes I made to this component in mind
  • Changes are clearly documented
    • Component docs include a changelog
    • Any new exposed functions or properties have docs
  • Changes extend to the Component Catalog
    • The Component Catalog is updated to use the newest version, if appropriate
    • The Component Catalog example version number is updated, if appropriate
    • Any new customizations are available from the Component Catalog
    • The component example still has:
      • an accurate preview
      • valid sample code
      • correct keyboard behavior
      • correct and comprehensive guidance around how to use the component
  • Changes to the component are tested/the new version of the component is tested
  • Component API follows standard patterns in noredink-ui
    • e.g., as a dev, I can conveniently add an nriDescription
    • and adding a new feature to the component will not require major API changes to the component
  • If this is a new major version of the component, our team has stories created to upgrade all instances of the old component. Here are links to the stories:
    • add your story links here OR just write this is not a new major version
  • Please assign the following reviewers:
    • Someone from your team who can review your PR in full and review requirements from your team's perspective.
    • team-accessibilibats-a11ybats - Someone from this group will review your PR for accessibility and adherence to component library foundations.
    • If there are user-facing changes, a designer. (You may want to direct your designer to the deploy preview for easy review):
      • For writing-related component changes, add Stacey (staceyadams)
      • For quiz engine-related components, add Ravi (ravi-morbia)
      • For a11y-related changes to general components, add Ben (bendansby)
      • For general component-related changes or if you’re not sure about something, add the Design group (NoRedInk/design)

@tesk9 tesk9 requested review from bendansby, a team and charbelrami and removed request for a team January 17, 2024 16:43
Copy link
Contributor

@charbelrami charbelrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tesk9 tesk9 merged commit 3b3f128 into master Jan 17, 2024
8 checks passed
@tesk9 tesk9 deleted the bat/modal-heading-responsiveness branch January 17, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants