Use database of partial paths to speed up bindings resolution #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OmarTawfik
changed the title
OmarTawfik
force-pushed
the
OmarTawfik/hooks-database-stitching
branch
from
1bef68e to
a5557a8
Compare
beta-ziliani
approved these changes
Dec 31, 2024
…attributes This *should* make it easier to construct a partial paths databases in which these nodes are endpoints.
This uses the added `save_checkpoint`/`restore_checkpoint` which rewind the allocation pointer in the `PartialPaths` arenas. For this to work properly, we also first `ensure_both_directions` in the database so that after that it doesn't need further mutation.
The database resolver will resolve all references at once by using a database of minimal partial paths.
… the `BindingGraph`
This makes it impossible to try to access definitions/references before resolving, and allows dropping the entire stack graph and database of partial paths used for resolution after they are no longer necessary.
…records The `definitions` test name is now a bit misleading since no definitions are retrieved there, but it's still where user source files are ingested.
OmarTawfik
force-pushed
the
OmarTawfik/hooks-database-stitching
branch
from
618cc52 to
f94b1c0
Compare
OmarTawfik
force-pushed
the
OmarTawfik/hooks-database-stitching
branch
from
f94b1c0 to
3c4fb33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing #1198 on latest after #1195 was merged.