Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_financial_report: Add Amount cur. to General Ledger totals if the account has not set currency #1254

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 27, 2024

FWP from 15.0: #1236 + #1256

Add Amount cur. to General Ledger totals if the account has not set currency

Related to #1235 (comment)

Please @pedrobaeza and @carlosdauden can you review it?

@Tecnativa

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 27, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat.

…als if the account has not set currency

Related to OCA#1235 (comment)

[FIX] account_financial_report: Avoid error in General ledger if the Show foreign currency checkbox is not checked.

Related to OCA#1236

TT51996
@victoralmau victoralmau force-pushed the 16.0-imp-account_financial_report-general_ledger_total branch from 2605aea to 0a2b273 Compare November 28, 2024 13:37
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1254-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1cb95fa into OCA:16.0 Nov 28, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a2c4d7f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants