Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] agreement #621

Merged
merged 26 commits into from
Feb 16, 2021
Merged

[14.0][MIG] agreement #621

merged 26 commits into from
Feb 16, 2021

Conversation

newtratip
Copy link
Member

@newtratip newtratip commented Feb 2, 2021 •
edited
Loading

Standard Migration

@newtratip newtratip marked this pull request as draft February 2, 2021 04:56
@newtratip newtratip force-pushed the 14.0-mig-agreement branch 3 times, most recently from 7e239bf to e09aa87 Compare February 2, 2021 09:45
@newtratip newtratip marked this pull request as ready for review February 2, 2021 10:17
@sergio-teruel
Copy link
Contributor

@newtratip please check out this PR #397

@sergio-teruel
Copy link
Contributor

Sorry the PR is this #578

@newtratip newtratip mentioned this pull request Feb 5, 2021
Closed
1 task
@newtratip
Copy link
Member Author

@sergio-teruel, I saw this PR #578 not plan to work anymore and then it will closed. Should I check out on this one or waiting another PR supersede #578

My question : agreement is changed to base_contract, it's ok. and I am migrating agreement_legal module. Should this module still be name agreement_legal or another name ?

Thanks !

@sergio-teruel
Copy link
Contributor

Hi @newtratip I not sure... I asked Alexis about PR (#578) (#578 (comment)) status... and he will not continue working on it, so I'm thinking... Why do we go to change the name...???
I think that we continue with "agreement" name.

sergio-teruel
sergio-teruel approved these changes Feb 14, 2021
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little comment..

agreement/views/agreement.xml Outdated Show resolved Hide resolved
agreement/views/agreement_type.xml Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sergio-teruel
Copy link
Contributor

Thanks @newtratip

ygol and others added 13 commits February 16, 2021 11:21
@ygol @newtratip
[MIG] agreement: Migration to 12.0
a7f9c2e
@bealdav @newtratip
FIX security issue + details
6762f93
@max3903 @newtratip
[FIX] Missing newline
f2f9c86
@rdc02271 @newtratip
Update translation
91531c8
@OCA-git-bot @newtratip
[UPD] README.rst
00a3db7
@liweijie0812 @newtratip
[IMP] move some notions from agreement_legal to agreement
1e48c0a 
we move the is_template field definition and the agreement.type model from
the agreement_legal module to the agreement module.

The fields are not displayed by default, unless the feature is enabled through a
technical feature group, this is configurable in the agreement_sale module (because agreement
in itself has no UI, and agreement_legal enables the feature by default)
@oca-travis @newtratip
[UPD] Update agreement.pot
34face7
@OCA-git-bot @newtratip
[UPD] README.rst
3f12651
@oca-transbot @newtratip
[IMP] New icon for agreement modules (svg file in agreement_legal)
90fb036
@pedrocs-exo @newtratip
agreement 12.0.1.0.1
7b90b14
@newtratip
[IMP] agreement,agreement_legal: support activities
08a789b 
- The `agreement` model now features mail and activities from its base module.
- The `agreement_legal` module doesn't need to add mail support now.
- Add activities to form views.

@Tecnativa TT22477
@extrememicro @newtratip
agreement 12.0.1.1.0
c0f93a4
@oca-transbot @newtratip
Update translation files
9879996 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-agreement
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement/
@newtratip newtratip force-pushed the 14.0-mig-agreement branch 2 times, most recently from 7dac775 to b4eeb47 Compare February 16, 2021 07:24
@newtratip
Copy link
Member Author

Additional update, I check out this PR #628

sergio-teruel
sergio-teruel approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-621-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e5f03e8 into OCA:14.0 Feb 16, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d41be91. Thanks a lot for contributing to OCA. ❤️

@newtratip newtratip deleted the 14.0-mig-agreement branch February 16, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.