[16.0][MIG] contract: Migration to 16.0 #887

wpichler · 2022-10-24T13:16:51Z

#880

wpichler · 2022-10-25T06:07:27Z

One check is still not working - but i assume this is an error on odoo side - look at: odoo/odoo#104009

I could need help a the pre-commit steps - i don't get the point what should be wrong here...

pedrobaeza · 2022-11-03T18:58:23Z

Please cherry-pick eda6d54

pedrobaeza · 2022-11-04T07:23:03Z

You can integrate #894 as well. Can you please check the tests in the CI?

wpichler · 2022-11-04T07:32:48Z

Done. There is only one test which fails - and this test does fail because of a bug in odoo core (imho). I can disable this test for now....

Here is my bug report for this odoo bug
odoo/odoo#104009

wpichler · 2022-11-04T08:56:14Z

I did take an other look on the failed test - and i don't get the point what is wrong here. In the test test_cron_recurring_create_invoice_multi_company it just creates the first account.move Form - this does try to access the member name - which is a compute field - so the compute functions triggers with a NewId Object - but in the compute function it does try to compute the name for all the NewId Objects from the past as it seems. And this does fail, because it can't compare agains't NewId.

Why are there that many NewId records in the compute function ?

Can we add some sort of flush / invalidate before the test to get rid of the NewId Objects ? Why are they don't get closed on the other tests ?

gkliska · 2022-11-07T14:32:08Z

contract/views/contract_template.xml

+                    <field
+                        name="contract_line_ids"
+                        widget="section_and_note_one2many"
+                        nolabel="1"


colspan="2"
Looks much better taking whole form width.

rafaelbn · 2022-12-02T10:20:10Z

/ocabot migration contract

victoralmau · 2022-12-07T07:42:10Z

Please cherry-pick #902

wpichler · 2022-12-07T10:11:43Z

@pedrobaeza There is just one test failing - and i am not able to fix it - because i think that it is because of a bug in the odoo account module directly. See odoo/odoo#104009

Should i disable this test so that we can merge this ?

contract/views/res_partner_view.xml

contract/models/contract.py

contract/models/contract_line.py

contract/models/contract.py

pedrobaeza · 2022-12-07T11:51:07Z

There is just one test failing - and i am not able to fix it - because i think that it is because of a bug in the odoo account module directly. See odoo/odoo#104009

Should i disable this test so that we can merge this ?

I think we should push for the solution. It has been already tagged, so I expect a response from Odoo soon. You can also push through an enterprise ticket.

About the analytic thing, you should convert it to the new format.

flotho · 2022-12-27T08:32:38Z

hi @rousseldenis any chance to have a final review ?

pedrobaeza · 2023-01-03T17:15:00Z

#894 should be cherry-picked as well

pedrobaeza · 2023-01-03T17:16:21Z

Another investigation line is that now invoices can't be created through Form, but through pure code, like it has been done in OCA/commission@2cd32a6

wpichler · 2023-01-16T07:12:07Z

@pedrobaeza It does look good now - is something missing for the final merge ? Reviews ?

wpichler · 2023-01-30T14:49:21Z

What is missing on this PR to get approived and merged ?

Currently translated at 91.0% (285 of 313 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/tr/

- Improve invoice generation through cron Avoid too much sql queries by iterating on first search Avoid performances problems through invoices ids isntead of recordset - Improve tests Adds multi company tests - Add a generation type on contract Add a generation type on contract that allows to generate other document than invoice (e.g. sale order) - Allows to get several functions to create recurring documents - Set visibility on button to show invoices - Add generation_type field - Update button visibility - Simplify test flow - Use Odoo conventions for methods - Add explicit cron create type for invoices - Improve function call for cron recurring creates - Improve multi-company tests / don't break former tests structure - Fix forwardport from 14.0 OCA#741

…ce: from contract_sale to contract

TT29820

Currently translated at 100.0% (316 of 316 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/es_AR/

Currently translated at 93.3% (295 of 316 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/fr/

Currently translated at 100.0% (317 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/es_AR/

Currently translated at 93.0% (295 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/fr/

Currently translated at 68.7% (218 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/de/

Currently translated at 79.8% (253 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/pt_BR/

Currently translated at 91.7% (291 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/es/

…rrect values of other fields (team_id for example). TT39934

…date)

In v14, the `string` attribute of the buttons is shown directly in UI. The tooltips are now put through `title` attribute. As that was the original intention, let's switch `string` to `title`.

pedrobaeza · 2023-03-15T11:39:33Z

Squash done, so merging:

/ocabot merge nobump

OCA-git-bot · 2023-03-15T11:39:46Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-887-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-03-15T11:46:31Z

Congratulations, your PR was merged at 70f8bca. Thanks a lot for contributing to OCA. ❤️

max3903 added this to the 16.0 milestone Oct 24, 2022

wpichler force-pushed the 16.0-mig-contract branch 2 times, most recently from 9b9f136 to c869e1a Compare October 24, 2022 18:24

wpichler force-pushed the 16.0-mig-contract branch from c869e1a to 5a8fc96 Compare October 25, 2022 06:23

gkliska reviewed Nov 7, 2022

View reviewed changes

OCA-git-bot mentioned this pull request Dec 2, 2022

Migration to version 16.0 #880

Open

14 tasks

rafaelbn added the needs review label Dec 2, 2022

rousseldenis added the migration label Dec 7, 2022

rousseldenis requested changes Dec 7, 2022

View reviewed changes

contract/views/res_partner_view.xml Outdated Show resolved Hide resolved

contract/models/contract.py Outdated Show resolved Hide resolved

contract/models/contract_line.py Outdated Show resolved Hide resolved

contract/models/contract_line.py Outdated Show resolved Hide resolved

rousseldenis reviewed Dec 7, 2022

View reviewed changes

contract/models/contract.py Outdated Show resolved Hide resolved

wpichler force-pushed the 16.0-mig-contract branch from 3e4d6de to 8172c90 Compare January 12, 2023 17:00

urvisha-serpentcs mentioned this pull request Jan 13, 2023

[16.0][MIG] contract_sale: Migration to 16.0 #915

Closed

wpichler requested review from rousseldenis and pedrobaeza and removed request for rousseldenis and pedrobaeza January 30, 2023 14:49

tate11 and others added 21 commits March 15, 2023 12:38

Translated using Weblate (Turkish)

d8f90f2

Currently translated at 91.0% (285 of 313 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/tr/

[FIX] contract: add default_move_type in context

e230ba9

[FIX] contract: change where security is given to group_account_invoi…

9d17314

…ce: from contract_sale to contract

[FIX] contract: Remove noupdate in mail template data

2863993

TT29820

Translated using Weblate (Spanish (Argentina))

7bf498c

Currently translated at 100.0% (316 of 316 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/es_AR/

Translated using Weblate (French)

3390020

Currently translated at 93.3% (295 of 316 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/fr/

[15.0][IMP] contract : show tags with colors in the contract

ad929e2

Translated using Weblate (Spanish (Argentina))

bbfd083

Currently translated at 100.0% (317 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/es_AR/

Translated using Weblate (French)

aca5577

Currently translated at 93.0% (295 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/fr/

Translated using Weblate (German)

a1b055a

Currently translated at 68.7% (218 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/de/

[IMP] contract: Use _prepare_home_portal_values() function.

56f4b44

Translated using Weblate (Portuguese (Brazil))

c4b6167

Currently translated at 79.8% (253 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/pt_BR/

Translated using Weblate (Spanish)

e4a8461

Currently translated at 91.7% (291 of 317 strings) Translation: contract-15.0/contract-15.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract/es/

[IMP] contract: Set invoice_user_id field with Form() to apply the co…

d381d11

…rrect values of other fields (team_id for example). TT39934

[IMP] Add link to contract in invoice chatter

e79298d

[FIX] contract: bug onchange date_start (comparison between bool and …

1a9a2fd

…date)

[IMP] contract: Set fixed start dates in test contracts

8c00427

[FIX] contract: Switch string > title in buttons

8c269f0

In v14, the `string` attribute of the buttons is shown directly in UI. The tooltips are now put through `title` attribute. As that was the original intention, let's switch `string` to `title`.

[IMP] contract: pre-commit stuff

c72ead9

[MIG] contract: Migration to 16.0

10e9287

pedrobaeza force-pushed the 16.0-mig-contract branch from 3cfdd0d to 10e9287 Compare March 15, 2023 11:38

OCA-git-bot added the bot is merging ⏳ label Mar 15, 2023

OCA-git-bot merged commit 715370a into OCA:16.0 Mar 15, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 15, 2023

wpichler deleted the 16.0-mig-contract branch March 15, 2023 12:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] contract: Migration to 16.0 #887

[16.0][MIG] contract: Migration to 16.0 #887

wpichler commented Oct 24, 2022 •

edited

Loading

wpichler commented Oct 25, 2022

pedrobaeza commented Nov 3, 2022

pedrobaeza commented Nov 4, 2022

wpichler commented Nov 4, 2022

wpichler commented Nov 4, 2022

gkliska Nov 7, 2022

rafaelbn commented Dec 2, 2022

victoralmau commented Dec 7, 2022

wpichler commented Dec 7, 2022

pedrobaeza commented Dec 7, 2022

flotho commented Dec 27, 2022

pedrobaeza commented Jan 3, 2023

pedrobaeza commented Jan 3, 2023

wpichler commented Jan 16, 2023

wpichler commented Jan 30, 2023

pedrobaeza commented Mar 15, 2023

OCA-git-bot commented Mar 15, 2023

OCA-git-bot commented Mar 15, 2023

[16.0][MIG] contract: Migration to 16.0 #887

[16.0][MIG] contract: Migration to 16.0 #887

Conversation

wpichler commented Oct 24, 2022 • edited Loading

wpichler commented Oct 25, 2022

pedrobaeza commented Nov 3, 2022

pedrobaeza commented Nov 4, 2022

wpichler commented Nov 4, 2022

wpichler commented Nov 4, 2022

gkliska Nov 7, 2022

Choose a reason for hiding this comment

rafaelbn commented Dec 2, 2022

victoralmau commented Dec 7, 2022

wpichler commented Dec 7, 2022

pedrobaeza commented Dec 7, 2022

flotho commented Dec 27, 2022

pedrobaeza commented Jan 3, 2023

pedrobaeza commented Jan 3, 2023

wpichler commented Jan 16, 2023

wpichler commented Jan 30, 2023

pedrobaeza commented Mar 15, 2023

OCA-git-bot commented Mar 15, 2023

OCA-git-bot commented Mar 15, 2023

wpichler commented Oct 24, 2022 •

edited

Loading