Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_br_purchase #1841

Merged
merged 405 commits into from
Jun 3, 2022
Merged

[14.0][MIG] l10n_br_purchase #1841

merged 405 commits into from
Jun 3, 2022

Conversation

marcelsavegnago
Copy link
Member

@marcelsavegnago marcelsavegnago commented Mar 22, 2022 •
edited
Loading

Depends #1688

  • acertar a posição do campo fiscal operation do form do pedido de compras
  • Testar os testes 👯 😄
  • Reorganizar os commits

@marcelsavegnago marcelsavegnago mentioned this pull request Apr 2, 2022
Closed
47 tasks
@marcelsavegnago marcelsavegnago marked this pull request as ready for review April 2, 2022 16:21
@marcelsavegnago marcelsavegnago requested a review from sadamo April 5, 2022 18:30
@marcelsavegnago marcelsavegnago force-pushed the 14.0-mig-l10n_br_purchase branch from 214cc70 to 8050d42 Compare May 17, 2022 19:39
@rvalyi
Copy link
Member

rvalyi commented May 20, 2022

@marcelsavegnago mesma coisa que eu comentei pro l10n_br_sale aqui #1854 (comment)
Se puder abrir um outro PR tecnico do l10n_br_purchase em cima da migração do l10n_br_account eu acho que seria uma boa para testar melhor e ver os testes...

@marcelsavegnago
Copy link
Member Author

marcelsavegnago commented May 20, 2022 •
edited
Loading

@marcelsavegnago mesma coisa que eu comentei pro l10n_br_sale aqui #1854 (comment) Se puder abrir um outro PR tecnico do l10n_br_purchase em cima da migração do l10n_br_account eu acho que seria uma boa para testar melhor e ver os testes...

@rvalyi #1915

@marcelsavegnago marcelsavegnago force-pushed the 14.0-mig-l10n_br_purchase branch from da0b030 to 68b109a Compare May 27, 2022 16:53
@rvalyi rvalyi mentioned this pull request May 27, 2022
Closed
@marcelsavegnago marcelsavegnago force-pushed the 14.0-mig-l10n_br_purchase branch 2 times, most recently from 5bf2a15 to f8f68b0 Compare May 30, 2022 16:47
@marcelsavegnago marcelsavegnago force-pushed the 14.0-mig-l10n_br_purchase branch from ccaf24c to 99f148f Compare June 2, 2022 14:59
@marcelsavegnago
Copy link
Member Author

All green :)
cc @rvalyi @renatonlima @douglascstd @augustodinizl @netosjb @felipemotter @vanderleiromera @mbcosta

augustodinizl
augustodinizl approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@augustodinizl augustodinizl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelsavegnago marcelsavegnago requested review from rvalyi and mileo June 2, 2022 15:20
mbcosta and others added 17 commits June 3, 2022 08:27
@mbcosta @marcelsavegnago
[IMP] Purchase Report with BR fields.
10462d3
@mbcosta @marcelsavegnago
[REF] Demo data, method _onchange_product_id_fiscal need to be call t…
9246618 
…o filled BR fiscal fields.
@oca-travis @marcelsavegnago
[UPD] Update l10n_br_purchase.pot
4e1f8eb
@OCA-git-bot @marcelsavegnago
l10n_br_purchase 12.0.4.4.0
afc80c4
@mbcosta @marcelsavegnago
[MIG] l10n_br_purchase: Migration to 13.0
494d74b
@mbcosta @marcelsavegnago
[MIG] Objects account.invoice and account.invoice.line change to acco…
d7bbabd 
…unt.move and account.move.line .
@mbcosta @marcelsavegnago
[REN] Rename files because of the change the object account.invoice t…
9735a64 
…o account.move .
@mbcosta @marcelsavegnago
[MIG] Fields Manytomany inherit from Fiscal Mixin need to defined in …
179cbd2 
…the object.
@mbcosta @marcelsavegnago
[MIG] Field fiscal_position was removed from Search View.
7279672
@mbcosta @marcelsavegnago
[MIG] Field company_id was removed from Purchase Line Tree View.
01f0529
@mbcosta @marcelsavegnago
[MIG] Method onchange for Purchase in account.move was renamed and fi…
47a10ca 
…eld account_id is not necessary informed anymore.
@mbcosta @marcelsavegnago
[MIG] Injection Brazilian Fiscal fields in Purchase Line View.
d8b4b8c
@mbcosta @marcelsavegnago
[UPD] History migration.
0ee33b7
@mbcosta @marcelsavegnago
[MIG] Now there are a specific method to pass fields in creation of a…
f87f665 
…ccount.move.line .
@marcelsavegnago
[IMP] l10n_br_purchase: black, isort, prettier
980a5e8
@marcelsavegnago
[MIG] l10n_br_purchase: Migration to 14.0
eef56da
@marcelsavegnago
[IMP] l10n_br_purchase: add service_type_id
5a90f9f
@marcelsavegnago marcelsavegnago force-pushed the 14.0-mig-l10n_br_purchase branch from 3b1ebb1 to 5a90f9f Compare June 3, 2022 11:27
@marcelsavegnago
Copy link
Member Author

marcelsavegnago commented Jun 3, 2022 •
edited
Loading

Pessoal.. Bora mesclar esta PR e deixar os warnings do l10n_br_account_payment order para ser resolvido na PR #1953 ?

@mbcosta
Copy link
Contributor

mbcosta commented Jun 3, 2022

Concordo @marcelsavegnago o merge do l10n_br_purchase não tem relação com o l10n_br_account_payment_order

rvalyi
rvalyi approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depois a gente vê de adicionar vc nos contribuídores e o README, mas dá para fazer merge já sim. Obrigado pelo trabalho!

@rvalyi
Copy link
Member

rvalyi commented Jun 3, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1841-by-rvalyi-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 47461d5 into OCA:14.0 Jun 3, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b1f265b. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 14.0-mig-l10n_br_purchase branch June 3, 2022 18:11
@marcelsavegnago marcelsavegnago added this to the 14.0 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanderleiromera vanderleiromera vanderleiromera approved these changes

@augustodinizl augustodinizl augustodinizl approved these changes

@douglascstd douglascstd douglascstd approved these changes

@felipemotter felipemotter felipemotter approved these changes

@mbcosta mbcosta mbcosta approved these changes

@renatonlima renatonlima renatonlima approved these changes

@rvalyi rvalyi rvalyi approved these changes

@antoniospneto antoniospneto Awaiting requested review from antoniospneto

@sadamo sadamo Awaiting requested review from sadamo

@mileo mileo Awaiting requested review from mileo

Assignees
No one assigned
Labels
14.0 approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.