[16.0][ADD] product_list_price_from_pricelist: Automatically compute product list prices based on a pricelist. #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
approved these changes
Jan 21, 2025
pedrobaeza
reviewed
Jan 22, 2025
carlos-lopez-tecnativa
force-pushed
the
16.0-add-product_list_price_from_pricelist
branch
2 times, most recently
from
d4ef689 to
aefa06b
Compare
pedrobaeza
reviewed
Jan 23, 2025
product_list_price_from_pricelist/views/res_config_settings_views.xml
Outdated
Show resolved
Hide resolved
product_list_price_from_pricelist/views/res_config_settings_views.xml
Outdated
Show resolved
Hide resolved
|
|
||
| - Go to `Sales` -> `Configuration` -> `Settings`. | ||
| - In the `Pricing` section, select the `Pricelist to compute sale price` created in the previous step. | ||
| - Save the configuration |
There was a problem hiding this comment.
I think you should mention here also the main company thing.
There was a problem hiding this comment.
Updated, please let me know if now is ok for you
| template.write({"list_price": new_price}) | ||
| return True | ||
|
|
||
| def _can_update_product_price(self): |
There was a problem hiding this comment.
Instead of having a method that gets the domain and then do a bool operation, do a method that returns the domain, and apply it directly on _get_all_templates_from_pricelist_item for getting the applied items, returning empty if not applicable. This way, the logic is more direct.
There was a problem hiding this comment.
Updated, please let me know if now is ok for you
carlos-lopez-tecnativa
force-pushed
the
16.0-add-product_list_price_from_pricelist
branch
from
aefa06b to
8530bcc
Compare
…t list prices based on a pricelist.
carlos-lopez-tecnativa
force-pushed
the
16.0-add-product_list_price_from_pricelist
branch
from
8530bcc to
b8b0ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT54561
@Tecnativa @pedrobaeza @pilarvargas-tecnativa @chienandalu could you please review this, thanks!