Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] product_pack: Migration to 18.0 #189

Open
wants to merge 100 commits into
base: 18.0
Choose a base branch
from

Conversation

ALopez-Adhoc
Copy link

No description provided.

jjscarafia and others added 30 commits November 20, 2024 09:42
INIT

ADD pot files and module for agrimesores
IMP product pack to support surveyor packs

IMP pack description

IMP add product pack standar functionality for v8 and general improvements

IMP discounts and portal distributors permissions

FIX product_pack license and author

FIX prod pack available

IMP pack to restrict company in products

FIX pack company restriction
IMP product_pack format

FIX fix_digits_compute_to_digits

IMP IMPORTANT imprrovements on product pack, get pack with sale order constraint

IMP use constraint on sale line and not sale order for product packs

IMP implement totalice price on product pack

IMP update pack manifest

FIX prod pack copy sale order

FIX contraint

IMP compt with other modules

FIX prod pack @api.multi
9.0 FIX filter the taxes by company (OCA#111)
* [REL] replace __openerp__ for __manifest__

* [REL] replace openerp imports for odoo

* [REL] some python3 exceptions

* [REL] replace openerp by odoo on xml files

* [REL] delete utf-8 line on python files

* [REL] some minor fixes for migration to v11

* [FIX] runbot link
* [FIX] xml files names

* [REL] migration product_pack to 11.0
* [FIX] Update README
* [FIX] remove openerp tags and data tags
* [IMP] change some funtion to improve funcionality
* [FIX] change name to xml and .py files according guidelines
* [FIX] remove api.one decorators

* [FIX] update readme

* [FIX] Remove "encoding: utf-8"

* [FIX] remove api.multi, string not necesary and some other fixes

* [FIX] demo data to separate according Guidelines

* [FIX] fix names in fields

* [FIX] remove executable
* [ADD] product_pack: Add compatibility with website_sale.

* [ADD] product_pack: Allow product pack modify

* [ADD] product_pack: In sale order do not let to delete/modify a line that
belongs to a pack

* [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in
product.

* [ADD] product_pack: Do not compute price in cart for components_price packs

[FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187)

* [FIX] product_pack: Pack line price fixed (take into account pricelist)

Proper compute pack line price using price instead of list_price

* [FIX] product_pack: Allow Modidy Pack only showed for Components price packs

* [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if
needed.
…mplate view (OCA#189)

[FIX] we add prefetch_fields becase if not the stock it's no correct when this method it's call from website (OCA#191)
…scount. (OCA#197)

Formerly was only taking into account the product packs discount, now take
into account both discounts.

Also we simplify the way that get_sale_order_line_vals works and now is
simplier and use Odoo's onchange methods to compute the lines values.

[FIX] product_pack: Pack component now have the tax of the company (OCA#198)

Before this fix the product's packs new sale order line have multiple taxes:
one por each company. Actually only need to add the taxes realated to the
sale order's company.

[FIX] product_pack: compute proper components prices (OCA#199)

In some cases the values were prefetched and it was throwing bad prices.
we add prefetch_fields to the context of the packs and that solve it.

[FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (#201)

* [FIX] product_pack: Do not reset packs components when confirm sale order.

If a sale order is updated from the website whrn confirm the order we do
not expand the pack, we usit as it is.

* [ADD] product_pack: Allow modify pack from backend/website

Now we can choose if the product can be modified in the only int he backend or
if can be modified also in the frontend by the customers.

* [FIX] lint
Currently translated at 95.6% (43 of 45 strings)

Translation: product-pack-12.0/product-pack-12.0-product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-product_pack/pt/
@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-product_pack branch 5 times, most recently from 16e8e5b to 16af869 Compare December 2, 2024 19:00
@ALopez-Adhoc
Copy link
Author

@augusto-weiss Hi Augusto, thank you for the feedback. The mentioned changes have now been included. Please review them if there are ok checking the last commit. Any additional feedback is welcome.

@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-product_pack branch 2 times, most recently from 1992ea8 to 20e728f Compare December 5, 2024 15:46
@ALopez-Adhoc
Copy link
Author

@augusto-weiss Augusto, the commit where the changes requestes was rolled back due to inconsistencies with nested pricelist when creating sales orders. We are going to mantain the actual flow until the mentioned issue is corrected.

@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-product_pack branch from 20e728f to 65e9489 Compare December 5, 2024 16:18
Copy link

@nicolascol nicolascol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hspl-vegra
Copy link

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@HeliconiaSolutions HeliconiaSolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally reviewed, LGTM.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this having the latest changes in previous branches?

product_pack/models/product_product.py Outdated Show resolved Hide resolved
@nicolascol
Copy link

Hi @pedrobaeza
Could you merge this PR or does it need changes?
Functionally it's OK

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what about my previous comment about having all the changes in previous branches?

product_pack/views/product_pack_line_views.xml Outdated Show resolved Hide resolved
@ALopez-Adhoc
Copy link
Author

ALopez-Adhoc commented Jan 6, 2025

@pedrobaeza Excuse me for asking, what changes/branches are you referring to? This PR migrates from the most recent version from its start date, having all the changes included in the productive branch of version 17.0 to that date. I assume you are referring to the updates that have been from that date onwards in the 17.0 branch

@pedrobaeza
Copy link
Member

Yeah, that's it, and it's only for being sure.

@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-product_pack branch from a822d6b to 8a749f9 Compare January 10, 2025 14:18
@ALopez-Adhoc
Copy link
Author

@pedrobaeza This pr is up to date with the latest changes. Ready to merge if ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.