-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] sale_product_pack: Migration to 18 #190
Open
ALopez-Adhoc
wants to merge
82
commits into
OCA:18.0
Choose a base branch
from
adhoc-dev:18.0-mig-sale_product_pack
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADD] icon.png
add a Roadmap section to the readme for creating sale_stock_product_pack
If not done this way, we can experiment ORM problems with cache misses.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
…ame place Previous technique was trying to access `pack_parent_line_id` related values that are not set due to the mangling on virtual records/creation phase, provoking an ORM error, but there's no need of such complex code, as we only need to set price_unit to 0 when preparing vals without the need of overriding other methods.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
Translated using Weblate (Spanish) Currently translated at 86.7% (13 of 15 strings) Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/es/
[UPD] Update sale_product_pack.pot sale_product_pack 12.0.1.0.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
It's helpfull to know directly if the sale order line is editable. If the sale order is edited from an api, onchange are not always triggered so having this field helps to raise an error. And it can be used to display in the view that the line is not editable.
[UPD] README.rst sale_product_pack 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/
Currently translated at 42.1% (8 of 19 strings) Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/nl/
Compatibility module between sale_product_pack and website_sale TT30385
…onsistent prices in some cases. TT32539
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-17.0/product-pack-17.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-17-0/product-pack-17-0-sale_product_pack/
Adapt the module sale_product_pack to the price refactor
Resolves an issue in the "Update Prices" action for packs. When update the pricelist, ignore all the "cero" lines, this is the components of packs "Detailed: Totalized in main product" or "Detailed - Ignored". We only want to update component lines if the parent pack is "Detailed - Detailed per component". Also keep in the so line the component discount settled in the parent pack settings. Steps to replicate the bug: 1. In a Sale Order add a product "Detailed - Detailed per component" 2. Save to see all the pack components 3. Change the pricelist to one with discount 4. Call the button action "Update Prices". Before this commit The price of the parent product gets updated, but the component prices remain unchanged. Even if the same product is added again (while retaining the first instance), the component prices show discrepancies. Now, when a pricelist with discounts is applied, all line items in the Sale Order including both parent and component products are updated accordingly.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-17.0/product-pack-17.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-17-0/product-pack-17-0-sale_product_pack/
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-17.0/product-pack-17.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-17-0/product-pack-17-0-sale_product_pack/it/
/ocabot migration sale_product_pack |
ALopez-Adhoc
force-pushed
the
18.0-mig-sale_product_pack
branch
from
December 5, 2024 19:49
1749305
to
a1f8c02
Compare
nicolascol
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @pedrobaeza |
marielejeune
suggested changes
Jan 9, 2025
ALopez-Adhoc
force-pushed
the
18.0-mig-sale_product_pack
branch
from
January 9, 2025 18:33
a08b8df
to
727dce8
Compare
ALopez-Adhoc
force-pushed
the
18.0-mig-sale_product_pack
branch
from
January 9, 2025 19:26
727dce8
to
10c85f2
Compare
@marielejeune Fixed the error with the Locked button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.