Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] auth_oidc: Migration to 18.0 #705

Merged
merged 40 commits into from
Oct 23, 2024
Merged

[18.0][MIG] auth_oidc: Migration to 18.0 #705

merged 40 commits into from
Oct 23, 2024

Conversation

ap-wtioit
Copy link
Contributor

info @wt-io-it

andreschenkels and others added 30 commits October 9, 2024 12:35
@andreschenkels @ap-wtioit
[ADD] auth_oidc module
0e91d23
@gurneyalex @ap-wtioit
Adapt to OCA standards
6c69d61 
update manifest, add README, update requirements.txt
@sbidoul @ap-wtioit
auth_oidc: improve docs
4e5a9b4 
Add some install instructions and configuration instructions
for keycloak.
@sbidoul @ap-wtioit
[MIG] auth_oidc: update dotfiles
467517c
@sbidoul @ap-wtioit
[MIG] auth_oidc from 10.0
fa18a6c
@sbidoul @ap-wtioit
auth_oidc: simplify and use "id_token token"
85c0216 
Avoid replacing the access token by the id token.
This may cause confusion.
Copy a little piece of code from auth_oauth() method,
to make the code easier to follow, and prepare for
implementing the authorization code flow.
@sbidoul @ap-wtioit
auth_oidc: _get_key and _map_token_values are not model methods
ea43cf1
@sbidoul @ap-wtioit
auth_oidc: cache _get_key
175bbc0
@sbidoul @ap-wtioit
auth_oidc: add authorization code flow
5b03dae
@sbidoul @ap-wtioit
auth_oidc: separate field for jwks uri
421abad
@sbidoul @ap-wtioit
auth_oidc: additional error logging
64db402
@sbidoul @ap-wtioit
auth_oidc: add author and maintainer
c68ba4d
@sbidoul @ap-wtioit
auth_oidc: improve docs, mention implicit flow is not recommended
13671f9
@sbidoul @ap-wtioit
auth_oidc: better nonce
1bd69a1
@sbidoul @ap-wtioit
auth_oidc: make client secret optional
1f0af05 
This is not a recommended scenario, but this prepares
the code for using PKCE
@sbidoul @ap-wtioit
auth_oidc: add PKCE support
3089ef1
@sbidoul @ap-wtioit
auth_oidc: demo data and basic test
d902ea9
@sbidoul @ap-wtioit
auth_oidc: slightly more robust parsing of claim mapping
7953262
@sbidoul @ap-wtioit
auth_oidc: split long method
6d587ff
@oca-travis @ap-wtioit
[UPD] Update auth_oidc.pot
2852bb3
@chafique-delli @ap-wtioit
[MIG] auth_oidc: Migration to 14.0
94767df
@paradoxxxzero @ap-wtioit
[FIX] auth_oidc: Fix werkzeug deprecated warning for url_encode, url …
b0c8ef9 
…decode
@theangryangel @ap-wtioit
[MIG] auth_oidc: Migration to 15.0
cb28f54
@ap-wtioit
[16.0][MIG] auth_oidc: Migration to 16.0
748cd1e
@ap-wtioit
[IMP] add AzureAD code flow provider
1f60335
@Ivorra78 @ap-wtioit
Added translation using Weblate (Spanish)
ac4a138
@sbidoul @ap-wtioit
[DOC] auth_oidc: fix images and convert to md
09bf51d
@mymage @ap-wtioit
Added translation using Weblate (Italian)
f029479
@ap-wtioit
[FIX] auth_oidc: set user_id for auth_oauth
27f964e 
inspired by OCA#336
@ap-wtioit
[FIX] auth_oidc: support keys without kid
3c025b6 
create an upstream merge request after
OCA#393 is merged
ap-wtioit and others added 9 commits October 9, 2024 12:35
@ap-wtioit
[IMP] auth_oidc: update documentation for 16.0.1.1.0
a463f61
@ap-wtioit
[IMP] auth_oidc: pre-commit fixes
0d84d9b
@ap-wtioit
[MIG] auth_oidc: Migration to 17.0
b6de18f
@ap-wtioit
[UPD] Update auth_oidc.pot
726c340
@OCA-git-bot @ap-wtioit
[BOT] post-merge updates
5f6975e
@weblate @ap-wtioit
Update translation files
cd39ddd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-17.0/server-auth-17.0-auth_oidc
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_oidc/
@xtanuiha @ap-wtioit
Added translation using Weblate (Chinese (Simplified) (zh_CN))
df1a17f
@xtanuiha @ap-wtioit
Translated using Weblate (Chinese (Simplified) (zh_CN))
e2da3ee 
Currently translated at 100.0% (20 of 20 strings)

Translation: server-auth-17.0/server-auth-17.0-auth_oidc
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_oidc/zh_CN/
@ap-wtioit
[IMP] auth_oidc: pre-commit auto fixes
fbc0116
@ap-wtioit
Copy link
Contributor Author

ap-wtioit commented Oct 9, 2024 •
edited
Loading

/ocabot migration auth_oidc

@OCA-git-bot
Copy link
Contributor

Sorry @ap-wtioit you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@ap-wtioit ap-wtioit mentioned this pull request Oct 9, 2024
Open
13 tasks
@sbidoul
Copy link
Member

sbidoul commented Oct 9, 2024

/ocabot migration auth_oidc

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 9, 2024
@sbidoul
Copy link
Member

sbidoul commented Oct 9, 2024

I compared with 17, and it's identical.

Compared to 16, there are a couple of PR's that landed there that were never ported to 17 (#573, #650) - not saying you need to do it, just a note.

hparfr
hparfr approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested yet)

@sbidoul
Copy link
Member

sbidoul commented Oct 23, 2024

Happy to merge this as soon as someone confirms it has been functionally tested.

wtaferner
wtaferner approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@wtaferner wtaferner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested within our own OAuth Provider Infrastructure and logged in successfully on the target test instance with OpenID

@sbidoul
Copy link
Member

sbidoul commented Oct 23, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-705-by-sbidoul-bump-nobump, awaiting test results.

@hparfr
Copy link
Contributor

hparfr commented Oct 23, 2024

Tested as well with keyloack; works as expected.

@OCA-git-bot OCA-git-bot merged commit 06c1bed into OCA:18.0 Oct 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 25c76aa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@wtaferner wtaferner wtaferner approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.