[17.0][MIG] auth_oauth_multi_token: Migration to 17.0 #742
Conversation
Allow multiple oauth login at the same time.
* cleanup, improve, docstrings * add tests
Nothing special. Just making linters happy and splitting the readme. @Tecnativa TT25619
Otherwise lookup is slow when there are many users.
Otherwise you can't delete a user.
This is cosmetic only, because this field is not used when auth_oauth_multi_token is installed.
Currently translated at 100.0% (15 of 15 strings) Translation: server-auth-16.0/server-auth-16.0-auth_oauth_multi_token Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_oauth_multi_token/it/
|
Hi @CRogos could this PR merged? |
There was a problem hiding this comment.
Could you have a look on your commits? Some of them should be squashed, and the last commit should be splitted into:
[IMP] auth_oauth_multi_token: pre-commit auto fixes
[MIG] auth_oauth_multi_token: Migration to 17.0
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
Code LGTM, but havn't tested yet.
Do you use odoo.sh? The last time I've tested this module it was not compatible with the login-as function of odoo.sh
|
Hi @kobros-tech Could you have a look on your commits? |
kobros-tech
force-pushed
the
17.0-mig-auth_oauth_multi_token
branch
from
3aed0b7 to
6182408
Compare
|
Hi all, I improved the PR more, and all contributions logs are mentioned. To have all log preserved here, there was a conflict arised and I guess the first PR was not made correctly as I had to resolve a conflict in another module which is out of scope. If I git rid of there commits and start on top of last merged commit in version 16.0 or to keep it as it is |
kobros-tech
force-pushed
the
17.0-mig-auth_oauth_multi_token
branch
from
eda2f56 to
497efa2
Compare
|
@kobros-tech can you squash these commits as well: also some of your content in the migration commit should be in the "[IMP] auth_oauth_multi_token: pre-commit auto fixes" commit as it was done in the original PR (but without the deb file)
|
|
please, make sure that the commit you mentioned that has pandoc file is not there, only the [MIG] commit which is clean as I guess. I don't understand why should I squash commits done for 16.0 and not for 17.0, could you explain? |
|
@kobros-tech In #694 the Commit history is according to the migration guide. Nevertheless, the "[IMP] auth_oauth_multi_token: pre-commit auto fixes" commit of #694 is correct beside of the *.deb file and should also exist in this PR. |
|
I need you to look at the log of commits, because the commit you are talking about is squashed already and pandoc file is not mentioned or tracked in the migration commit and you can review, thanks!
|
|
@CRogos |
There is no commit with pandoc file, but there is also no commit "[IMP] auth_oauth_multi_token: pre-commit auto fixes" which should be there.
|
thanks, now I understand what you mean. In fact I am not used to make two commits for migration, I have a point of view that I add it in a single commit, I don't mind you if you see it necessary here. |
|
@CRogos |
|
Yes, that is what I'm trying to explain. You need to split the commit and adapt the commit message. |
kobros-tech
force-pushed
the
17.0-mig-auth_oauth_multi_token
branch
from
497efa2 to
873af5f
Compare
|
@CRogos |
|
Better, but could you squash the yellow marked and correct the commit message of the last commit? |
| nolabel="1" | ||
| options="{'no_create': True, 'no_open': True}" | ||
| > | ||
| <tree limit="10"> |
There was a problem hiding this comment.
This node should be changed to <list
There was a problem hiding this comment.
Is list tag introduced in version 18.0 or version 17.0?
There was a problem hiding this comment.
you are totally right... got confused, sorry.
fixing git commits log history with keeping the changes the same for PR #694 this will enable me to migrate to 18.0