[16.0] stock_picking_batch_creation: Allows to split picking

[lmignon]

A new option 'Split picking exceeding the limits' on the wizard allow, when the system is not able to find a picking that fits the criteria to create the batch, to lower the criteria by removing those based on the volume, weight and number of lines. If a picking is found and you allow to split it, the system will try to split the picking so that the new picking fits the criteria and can be added to the batch.

Depends on:

• [16.0][ADD] stock_split_picking_dimension: Split picking based on dimension stock-logistics-workflow#1741

[jbaudoux]

Looks good.

The device can also define a limit of bins. I'll need this feature in v18.

As commented below, this needs to be split in multiple modules to not add new dependencies

[jbaudoux]

Suggested change

	nbr_lines, volume, weight = self._get_picking_max_dimensions()
	wizard = self.env["stock.split.picking"].with_context(active_ids=picking.ids)
	wizard.create(
	{
	"mode": "dimensions",
	"max_nbr_lines": nbr_lines,
	"max_volume": volume,
	"max_weight": weight,
	}
	# In base split module
	def _prepare_prepare_split_picking_wizard(self):
	return {
	"mode": self.split_picking_exceeding_limits_mode
	}
	# In split_dimension module
	def _prepare_prepare_split_picking_wizard(self):
	res = super()._prepare_prepare_split_picking_wizard()
	if self.split_picking_exceeding_limits_mode == "dimensions":
	nbr_lines, volume, weight = self._get_picking_max_dimensions()
	res.update({
	"mode": "dimensions",
	"max_nbr_lines": nbr_lines,
	"max_volume": volume,
	"max_weight": weight,
	})
	return res
	# In base split module
	def _split_first_picking_for_limit(self, picking):
	wizard = self.env["stock.split.picking"].with_context(active_ids=picking.ids)
	wizard.create(self._prepare_split_picking_wizard())

[jbaudoux]

Suggested change

	nbr_lines, volume, weight = self._get_picking_max_dimensions()
	return (
	picking.nbr_picking_lines > nbr_lines
	or picking.volume > volume
	or picking.weight > weight
	# In base split module
	def _is_picking_exceeding_limits(self, picking):
	return False
	# In split_dimension module
	def _is_picking_exceeding_limits(self, picking):
	if self.split_picking_exceeding_limits_mode == "dimensions":
	nbr_lines, volume, weight = self._get_picking_max_dimensions()
	return (
	picking.nbr_picking_lines > nbr_lines
	or picking.volume > volume
	or picking.weight > weight
	)
	return super()._is_picking_exceeding_limits(picking)

[jbaudoux]

Reviewing this again, I think we should split this into multiple modules.
The existing module should not depend on new modules (there are quite some modules to split by dimension).

I would move the split to a new module stock_picking_batch_creation_split defining split_picking_exceeding_limits and the mode split_picking_exceeding_limits_mode as a selection offering move and depending on stock_split_picking.
Edit: I think this move mode is useless. Maybe split_picking_exceeding_limits can be dropped and only the selection split_picking_exceeding_limits_mode kept with a default behavior as no split.

Then a module stock_picking_batch_creation_split_dimension that declares the mode by dimension and depends on stock_split_picking_dimension.

Then I can add a module stock_picking_batch_creation_split_bins that declares the mode by number of bins and would depend on stock_split_picking_nbr_bins.

[jbaudoux]

Move to stock_picking_batch_creation_split module