Detect COBOL variable in EXEC SQL, provides go to def, show refs and hover
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix sql stmt generation when stmt is exactly 72 char long - unify prefix on all preproc genereted lines
NeoKaios
changed the title
EXEC SQL, provides go to def, show refs and hover
|
Should be draft until #370 is merged. |
|
This seems to target #327, no? If yes I suggest to reference that in the commit message and/or in this PR as related issue. |
|
This PR introduces dependencies between libraries that I'd like to avoid as they would impair further extensibility of the LSP server. In addition the parser for SQL is not hardened against errors in SQL syntax. Those issues need to be fixed before this PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add-on to #370,
reactivate Sql preproc in the LSP and add references and location to cobol vars in sql exec blocks
The completion seems to fails inside such exec blocks -> the parser needs to be more robust
The new completion test needs to pass before merging this