Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CustomizableRenderComponent for dynamic component rendering and update component usage #4634

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

abhijith-trenser
Copy link
Contributor

@abhijith-trenser abhijith-trenser commented Dec 30, 2024

Context

  • Implemented a new CustomizableRenderComponent for dynamic rendering of both customization service components and default OSS components.
  • Integrated the new customizable rendering component into the LabellingFlow and LoadingIndicators components.
  • Created a custom hook and provider to manage and share services across the application.
  • This PR has been incorporated by FlyWheel.io

Changes & Results

  • Implemented a new functional component, CustomizableRenderComponent, to facilitate easy switching between OSS default components and customization service-provided components through dynamic rendering.
  • Developed a new hook and provider for accessing services directly across the application, eliminating the need to pass them through props.

Testing

  • Introduce a new customization method for a component.
  • Use CustomizableRenderComponent in the main component and add the default component as fallback.
  • Add the customizationId to link the component with the customization service.
  • User can render the customization-provided component in the application by registering it with the customizationId.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 10
  • Node version: 18.19.0
  • Browser: Chrome 131.0.6778.205

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit bff641a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6793659cf2e8d10008e7bff1

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit bff641a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6793659cfa2bba0008bc9fab
😎 Deploy Preview https://deploy-preview-4634--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Jan 8, 2025

we are reworking the customizationService so stay tuned until it is done

@abhijith-trenser
Copy link
Contributor Author

we are reworking the customizationService so stay tuned until it is done

Thank you for the information, @sedghi. Would you happen to have a feature branch or work item that could serve as a reference for the implementation?

@abhijith-trenser abhijith-trenser marked this pull request as draft January 22, 2025 09:50
@abhijith-trenser abhijith-trenser changed the title feat: Integrate CustomizationService with UiDialogService and support customized components in Annotation Labelling feat: Add CustomizableRenderComponent for dynamic component rendering and update component usage Jan 23, 2025
@abhijith-trenser abhijith-trenser force-pushed the feat/integrate-customization-service-with-ui-dialog-service branch from 247b7a3 to 8e39169 Compare January 23, 2025 09:27
@sedghi
Copy link
Member

sedghi commented Jan 23, 2025

Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience

@abhijith-trenser abhijith-trenser force-pushed the feat/integrate-customization-service-with-ui-dialog-service branch from d9d5415 to 79b8f42 Compare January 24, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants