Add r.slopeunits module #1279

mmacata · 2025-01-14T15:08:01Z

This PR adds r.slopeunits which is a GRASS GIS addon toolset that creates, cleans and calculate metrics for slope units. Additionally, optimal input values can be determined.

AUTHORS:

Main authors: Ivan Marchesini (@IvanMarchesini), Massimiliano Alvioli (@alvioli), CNR-IRPI
Markus Metz (@metzm) (translation to python, refactoring), Carmen Tawalika (@mmacata) (translation to python, refactoring), mundialis

init

core module

…ows-1.x Update pre-commit hook mundialis/github-workflows to v1.2.0

fix string formatting

Start linting

…te_metric

Add script to calculate metric

test01 completed

Linting Part 2

Split into multimodule

Fix a few typos

Small fixes

add options for r.watershed

make plainsmap optional

…b49fb46ed29ee42' git-subtree-dir: src/raster/r.slopeunits git-subtree-mainline: a5c5f66 git-subtree-split: e1bee74

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

black

[black] _{reported by reviewdog 🐶}

grass-addons/src/raster/r.slopeunits/r.slopeunits.optimize/r.slopeunits.optimize.py

Lines 342 to 344 in 45b67a7

    
           grass.message( 
        
               f"Writing to calcd.dat: {cvmin} {areamin} {out1} {out2} ..." 
        
           )

[black] _{reported by reviewdog 🐶}

grass-addons/src/raster/r.slopeunits/r.slopeunits.optimize/r.slopeunits.optimize.py

Lines 368 to 370 in 45b67a7

    
           grass.message( 
        
               f"Writing to current.txt: {ico} {cvmin} {areamin} {out1} {out2} ..." 
        
           )

src/raster/r.slopeunits/r.slopeunits.html

petrasovaa · 2025-01-14T16:12:58Z

Can I suggest looking at the contributing guidelines:
https://github.com/OSGeo/grass/blob/main/doc/development/style_guide.md

Specifically, there are several best practices that may be relevant here:
https://github.com/OSGeo/grass/blob/main/doc/development/style_guide.md#import-python-scripting-library
https://github.com/OSGeo/grass/blob/main/doc/development/style_guide.md#changing-computational-region
https://github.com/OSGeo/grass/blob/main/doc/development/style_guide.md#temporary-maps

flake: max-line-length = 88 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Apply suggestions by AP

src/raster/r.slopeunits/r.slopeunits.clean/r.slopeunits.clean.py

src/raster/r.slopeunits/r.slopeunits.create/r.slopeunits.create.py

src/raster/r.slopeunits/r.slopeunits.metrics/r.slopeunits.metrics.py

flake: max line length = 88 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

mmacata and others added 30 commits September 30, 2024 13:47

Initial commit

f1f4cc5

Update pre-commit hook mundialis/github-workflows to v1.2.0

f85ceac

init

42a170f

Merge pull request OSGeo#3 from mundialis/init

87d6409

init

core module

92bed7d

black

8d65a82

black

772791f

flake8

611a22c

flake8

d2277f0

flake8

9b607e3

Merge pull request OSGeo#4 from mundialis/core_module

03f97d8

core module

Merge pull request #1 from mundialis/renovate/mundialis-github-workfl…

36546ec

…ows-1.x Update pre-commit hook mundialis/github-workflows to v1.2.0

add script to calculate metric

c6cc45b

fix string formatting

38eea3d

Merge pull request OSGeo#5 from mundialis/string_format

6252b5a

fix string formatting

lint

5b0481a

start linting

e3f3a9e

Merge pull request OSGeo#7 from mundialis/lint

3f6e84b

Start linting

Merge branch 'main' of github.com:mundialis/r.slopeunits into calcula…

2bbfef0

…te_metric

Merge pull request OSGeo#6 from mundialis/calculate_metric

0b524f3

Add script to calculate metric

test01 completed

d5b7b8f

format

66b07e7

format

480d75b

Merge pull request OSGeo#8 from mundialis/test01

dae52bc

test01 completed

lint

2432d3d

Merge pull request OSGeo#9 from mundialis/lint2

40d1e00

Linting Part 2

split into multimodule

60a2507

Merge pull request OSGeo#10 from mundialis/split-addon

a835f20

Split into multimodule

move cleanup

d6d0635

adjust lint config to splitup

5aa7627

mmacata and others added 15 commits October 30, 2024 13:22

Merge pull request OSGeo#20 from mundialis/fix_few_typos

bead333

Fix a few typos

small fixes

7b0e386

Merge pull request OSGeo#22 from mundialis/small-fixes

3387986

Small fixes

add options for r.watershed

ecf38f2

fix flag usage and formatting

4617d94

formatting

bb10431

black formatting

f9e87c2

allow too many lines

3b5ec9c

make plainsmap optional

b45c97d

pass fully qualified names of input maps

4686c08

Merge pull request OSGeo#27 from mundialis/watershed_options

cdefc4e

add options for r.watershed

Merge branch 'main' into plainsmap_optional

04ad93f

Merge pull request OSGeo#28 from mundialis/plainsmap_optional

e1bee74

make plainsmap optional

Add 'src/raster/r.slopeunits/' from commit 'e1bee74e3e4d656d1bde93924…

f26e315

…b49fb46ed29ee42' git-subtree-dir: src/raster/r.slopeunits git-subtree-mainline: a5c5f66 git-subtree-split: e1bee74

remove duplicated config files

45b67a7

mmacata marked this pull request as ready for review January 14, 2025 15:21

mmacata mentioned this pull request Jan 14, 2025

r.slopeunits: prepare for move to GRASS GIS Addons repo mundialis/r.slopeunits#29

Closed

neteler added the new addon PR contains a new addon or issue proposes one label Jan 14, 2025

github-actions bot reviewed Jan 14, 2025

View reviewed changes

petrasovaa reviewed Jan 14, 2025

View reviewed changes

src/raster/r.slopeunits/r.slopeunits.html Outdated Show resolved Hide resolved

metzm and others added 2 commits January 15, 2025 14:59

Apply suggestions from code review

fde7647

flake: max-line-length = 88 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

import grass.script as gs

0c723c9

metzm mentioned this pull request Jan 15, 2025

Apply suggestions by AP mmacata/grass-addons#2

Merged

metzm and others added 2 commits January 15, 2025 15:54

improve usage of temporary region

2464bc0

Merge pull request #2 from metzm/r.slopeunits_mm

10a2c97

Apply suggestions by AP

neteler added the Python Related code is in Python label Jan 15, 2025

github-actions bot reviewed Jan 15, 2025

View reviewed changes

Apply suggestions from code review

aa6262a

flake: max line length = 88 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

metzm merged commit 509d306 into OSGeo:grass8 Jan 20, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add r.slopeunits module #1279

Add r.slopeunits module #1279

mmacata commented Jan 14, 2025 •

edited

Loading

github-actions bot left a comment

petrasovaa commented Jan 14, 2025

	grass.message(
	f"Writing to calcd.dat: {cvmin} {areamin} {out1} {out2} ..."
	)

	grass.message(
	f"Writing to current.txt: {ico} {cvmin} {areamin} {out1} {out2} ..."
	)

Add r.slopeunits module #1279

Add r.slopeunits module #1279

Conversation

mmacata commented Jan 14, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

petrasovaa commented Jan 14, 2025

mmacata commented Jan 14, 2025 •

edited

Loading