Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db.columns: Add separator= and exclude= options #3173

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

db.columns: Add separator= and exclude= options #3173

wants to merge 9 commits into from

Conversation

HuidaeCho
Copy link
Member

@HuidaeCho HuidaeCho commented Sep 22, 2023 •
edited
Loading

This PR adds separator= and exclude= options to allow a CSV-like output using comma and exclusion of selected columns. The default separator is still newline for compatibility.

@HuidaeCho HuidaeCho added enhancement New feature or request database Related to database management labels Sep 22, 2023
@HuidaeCho HuidaeCho changed the title db.columns: Add separator= option db.columns: Add separator= and exclude= options Sep 22, 2023
@neteler neteler added this to the 8.4.0 milestone Oct 5, 2023
wenzeslaus
wenzeslaus requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add exclusion and custom separator to the test? Existing functionality is already tested. It would be good to have also the new one covered.

db/db.columns/testsuite/test_dbcolumns.py
scripts/db.dropcolumn/testsuite/test_db_dropcolumn.py

@github-actions github-actions bot added C Related code is in C module labels Mar 31, 2024
@wenzeslaus wenzeslaus modified the milestones: 8.4.0, Future Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@HuidaeCho HuidaeCho

Labels
C Related code is in C database Related to database management enhancement New feature or request module
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
4 participants
@HuidaeCho @wenzeslaus @neteler @echoix