-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.out.vtk: replace dead WMS server with NASA GIBS WMS in docs (#4844) #4854
Conversation
r.out.vtk
: Replace dead WMS server with NASA GIBS WMS #4844
When I try the new example, I get the following error: > r.in.wms layers=BlueMarbleNG mapserver=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? output=wms_BlueMarbleNG
ERROR: WMS server error: b'<?xml version=\'1.0\' encoding="UTF-8"
standalone="no" ?>\n<!DOCTYPE ServiceExceptionReport SYSTEM
"http://schemas.opengis.net/wms/1.1.1/exception_1_1_1.dtd">\n<ServiceExceptionReport
version="1.1.1">\n<ServiceException
code="LayerNotDefined">\nmsWMSLoadGetMapParams(): WMS server error.
Invalid layer(s) given in the LAYERS parameter. A layer might be
disabled for this request. Check wms/ows_enable_request
settings.\n</ServiceException>\n</ServiceExceptionReport>\n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unrelated changes from this PR
@rohannallamadge: They were introduced in 90ba339 - it should be sufficient to revert the commit. As the changes were not there yesterday when I was making the review, I guess they slipped in together with your merge request. |
Even after 27412da that I would expect to be a fix, I am getting the same error. |
@@ -97,11 +97,11 @@ <h3>Spearfish example with RGB data</h3> | |||
g.region n=4926990 s=4914840 w=591570 e=607800 res=30 -p | |||
|
|||
# using r.in.wms to create RGB data to get a satellite coverage | |||
r.in.wms layers=global_mosaic mapserver=http://wms.jpl.nasa.gov/wms.cgi \ | |||
output=wms_global_mosaic | |||
r.in.wms layers=BlueMarbleNG url=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r.in.wms layers=BlueMarbleNG url=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? \ | |
r.in.wms layers=BlueMarble_NextGeneration url=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? \ |
@@ -97,11 +97,11 @@ <h3>Spearfish example with RGB data</h3> | |||
g.region n=4926990 s=4914840 w=591570 e=607800 res=30 -p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The computational region should be changed to follow the region and coordinate system of the WMS used. The same applies to the title -- it is not Spearfish example with RGB data
anymore.
@rohannallamadge: What was the meaning of the last commit? It seems that the only effect is that the unrelated changes in python/grass/jupyter slipped again in in 781db51 |
sir @pesekon2 Apologies for the confusion regarding the last commit. The issue arose because my OneDrive integration caused unintended changes to be merged automatically into the To resolve this and ensure a clean contribution, I have created a new branch |
Continued in #4897 |
This pull request updates the example in the
r.out.vtk
documentation. The previous WMS server (http://wms.jpl.nasa.gov/wms.cgi) is no longer available, causing the example to fail.Changes made:
Replaced the dead WMS server with NASA GIBS WMS (https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi).
Used the
BlueMarbleNG
layer for global imagery, which closely matches the original intent of the example.