Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.out.vtk: replace dead WMS server with NASA GIBS WMS in docs (#4844) #4854

Closed
wants to merge 8 commits into from

Conversation

rohannallamadge
Copy link
Contributor

This pull request updates the example in the r.out.vtk documentation. The previous WMS server (http://wms.jpl.nasa.gov/wms.cgi) is no longer available, causing the example to fail.

Changes made:

Replaced the dead WMS server with NASA GIBS WMS (https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi).
Used the BlueMarbleNG layer for global imagery, which closely matches the original intent of the example.

@github-actions github-actions bot added raster Related to raster data processing HTML Related code is in HTML module docs labels Dec 17, 2024
@pesekon2 pesekon2 changed the title Fix example in r.out.vtk: Replace dead WMS server with NASA GIBS WMS #4844 r.out.vtk: replace dead WMS server with NASA GIBS WMS in docs (#4844) Dec 19, 2024
@pesekon2
Copy link
Contributor

When I try the new example, I get the following error:

> r.in.wms layers=BlueMarbleNG mapserver=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi?       output=wms_BlueMarbleNG
ERROR: WMS server error: b'<?xml version=\'1.0\' encoding="UTF-8"
       standalone="no" ?>\n<!DOCTYPE ServiceExceptionReport SYSTEM
       "http://schemas.opengis.net/wms/1.1.1/exception_1_1_1.dtd">\n<ServiceExceptionReport
       version="1.1.1">\n<ServiceException
       code="LayerNotDefined">\nmsWMSLoadGetMapParams(): WMS server error.
       Invalid layer(s) given in the LAYERS parameter. A layer might be
       disabled for this request. Check wms/ows_enable_request
       settings.\n</ServiceException>\n</ServiceExceptionReport>\n'

@github-actions github-actions bot added Python Related code is in Python libraries notebook labels Dec 19, 2024
python/grass/jupyter/map.py Outdated Show resolved Hide resolved
python/grass/jupyter/map.py Outdated Show resolved Hide resolved
python/grass/jupyter/map3d.py Outdated Show resolved Hide resolved
python/grass/jupyter/map3d.py Outdated Show resolved Hide resolved
python/grass/jupyter/map3d.py Outdated Show resolved Hide resolved
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated changes from this PR

@pesekon2
Copy link
Contributor

Please remove unrelated changes from this PR

@rohannallamadge: They were introduced in 90ba339 - it should be sufficient to revert the commit. As the changes were not there yesterday when I was making the review, I guess they slipped in together with your merge request.

@pesekon2
Copy link
Contributor

pesekon2 commented Dec 27, 2024

When I try the new example, I get the following error:

> r.in.wms layers=BlueMarbleNG mapserver=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi?       output=wms_BlueMarbleNG
ERROR: WMS server error: b'<?xml version=\'1.0\' encoding="UTF-8"
       standalone="no" ?>\n<!DOCTYPE ServiceExceptionReport SYSTEM
       "http://schemas.opengis.net/wms/1.1.1/exception_1_1_1.dtd">\n<ServiceExceptionReport
       version="1.1.1">\n<ServiceException
       code="LayerNotDefined">\nmsWMSLoadGetMapParams(): WMS server error.
       Invalid layer(s) given in the LAYERS parameter. A layer might be
       disabled for this request. Check wms/ows_enable_request
       settings.\n</ServiceException>\n</ServiceExceptionReport>\n'

Even after 27412da that I would expect to be a fix, I am getting the same error.

@@ -97,11 +97,11 @@ <h3>Spearfish example with RGB data</h3>
g.region n=4926990 s=4914840 w=591570 e=607800 res=30 -p

# using r.in.wms to create RGB data to get a satellite coverage
r.in.wms layers=global_mosaic mapserver=http://wms.jpl.nasa.gov/wms.cgi \
output=wms_global_mosaic
r.in.wms layers=BlueMarbleNG url=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
r.in.wms layers=BlueMarbleNG url=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? \
r.in.wms layers=BlueMarble_NextGeneration url=https://gibs.earthdata.nasa.gov/wms/epsg4326/best/wms.cgi? \

@@ -97,11 +97,11 @@ <h3>Spearfish example with RGB data</h3>
g.region n=4926990 s=4914840 w=591570 e=607800 res=30 -p
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The computational region should be changed to follow the region and coordinate system of the WMS used. The same applies to the title -- it is not Spearfish example with RGB data anymore.

@echoix echoix linked an issue Dec 28, 2024 that may be closed by this pull request
@pesekon2
Copy link
Contributor

@rohannallamadge: What was the meaning of the last commit? It seems that the only effect is that the unrelated changes in python/grass/jupyter slipped again in in 781db51

@rohannallamadge
Copy link
Contributor Author

sir @pesekon2 Apologies for the confusion regarding the last commit. The issue arose because my OneDrive integration caused unintended changes to be merged automatically into the gh-phase branch.

To resolve this and ensure a clean contribution, I have created a new branch Mercator and submitted another PR with only the relevant changes.

@petrasovaa
Copy link
Contributor

Continued in #4897

@petrasovaa petrasovaa closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML libraries module notebook Python Related code is in Python raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Replace wms server in r.out.vtk example
3 participants