Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Various remaining pyrefact refactorings #4911

Merged
merged 9 commits into from
Jan 4, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Jan 3, 2025

This PR contains the remaining refactorings selected from a pyrefact run on the python/grass folder (it generated near 300 changed files, some weren't important or relevant, so they were reverted). It took the day to review through this.

These changes are miscellaneous, and not a lot of each kind to merit their own PRs, they are grouped together.

I finish this by removing ruff exclusions that were previously fixed, in this PR OR in other PRs. I commented out everything, and added back until there were no failures, and removed the exclusions that weren't placed back.

Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@echoix echoix merged commit dd87856 into OSGeo:main Jan 4, 2025
26 checks passed
@echoix echoix deleted the pyrefact-python-other branch January 4, 2025 23:31
@github-actions github-actions bot added this to the 8.5.0 milestone Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libraries notebook Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants