CI: Restrict default permissions on GitHub Actions workflows #4942
+43
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some fixes to the new security issues found by CodeQL for the
actions(GitHub Actions) language, added in #4940.I searched for the needed permissions as much as I could find, and I tested this PR as much as I could, even using my default branch. Why I say as much as I could? Well, my fork is a fork, and it is not in an organization, and I do not know exactly the remaining settings that are applied, but I still changed my actions settings (https://github.com/OSGeo/grass/settings/actions) to "Read repository contents and packages permissions", which is the new default for new repos after some date in 2023.
I suggest changing our settings to that, if possible (cc @neteler or @wenzeslaus). For organizations, it might be different, and I hope it isn't only possible at the org-level.