r.path: Support bitmask encoding CW from East #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
HuidaeCho
added
enhancement
HuidaeCho
force-pushed
the
r_path_bitmask_east
branch
from
0c898f5 to
f878072
Compare
echoix
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the power-of-two encoding CW from East (e.g., r.terraflow, ArcGIS).
The default bitmask encoding starts CW from NE, some programs use a 45-degree rotated (one bit shifted) version of the bitmask encoding (e.g. r.terraflow, ArcGIS). The new
-e(East) flag usesy=2^((log2(x)+1)%8)to convert the latter encoding to the default one before tracing.The PR also adds
-bflag to avoid breaking lines unnecessarily for single-direction paths.How to test in the NC sample dataset