-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GH Actions CI/CD testing #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update test helper add gisBase to initGRASS Fix logic in skip_if_not add skip_if_not to tests fix tests due to base R levels use grassdb at /tmp
Update CRAN badge and simplify test helper
Revert "use r-lib/actions/setup-r@v2 in releasebranch" This reverts commit 8cb701b. use RSPM but build terra from source due to conflict with version from ubuntugis PPA
unlink .gislock at end of test test changing mapset
add test for legacyExecOption restore defaults for test-options to avoid side effects add test for useInternOption add test for stop_on_no_flags_parasOption
A couple of review questions:
|
rsbivand
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in PR, I forgot I needed to re-load the browser page to generate the review link.
Thanks for the comments - some follow-up below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create GH actions workflows for CI/CD testing of rgrass. This is initially based on Ubuntu only, but the idea is to expand later to include other platforms.
Summary
Three GH action workflows were created:
R package dependencies are installed from RSPM except terra, which is built from source due to conflict with GDAL coming from the ubuntugis PPA that is used in the docker images.
Completeness
Initial test suite has ~60% code coverage (with the aim to increase this later). However, with tests relating to
sp
disabled (see below), coverage is currently 50%.Tests that read GRASS rasters as
SpatialGridDataFrame
usingsp
are currently disabled for CRAN and CI becausesp
does not interpret the WTK string in some cases. This occurs specifically in thegetLocationProj
function, which is also used byread_RAST
atsp::CRS(gLP)
wheregLP
is the WTK output from GRASS in thergrass:::.read_rast_non_plugin_ng(...)
function. There is no problem when usingterra::crs(gLP)
. This may relate to edzer/sp#111.Other changes
No changes were made to the R package itself (other than some minor formatting/spaces).