-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for conf.d like configuration handling. #47
base: master
Are you sure you want to change the base?
Conversation
Fixed .travis.yml after trusty image upgrade.
Moved haproxy_cfg_path into defaults.
Usefull while testing in local.
Looks really interesting! However it might take some time from my side for it to be merged. I'll keep you posted. |
NP, for now I'll use my forked version. I may in the meantime find a better way to inject additional configuration files than using Assemble should really be a handler but I did not manage to find a good way (at simple one) to fire it from the main task when files are changed or removed other than duplicating it as task which does not look good to me (ansible newbie :)). |
Nice change. The assemble as a task is probably better than running it as a handler because it facilitates dropping configuration parts into conf.d outside the scope of this role while still maintaining idempotency in regenerating the compiled config. :) |
owner: root | ||
group: root | ||
mode: 0640 | ||
validate: 'haproxy -f %s -c' | ||
validate: "{{ haproxy_validation_command }}" | ||
notify: restart haproxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This notification is unnecessary. Only the assemble
tasks below need to notify the reload handler.
With haproxy version 1.7 you can just pass |
You can see it implemented at #34 |
haproxy.cfg
file with this final configuration file will be assembled from all files residing inside ofhaproxy_cfg_path
.It will give users option to add own files into the main configuration for cases which are not covered with standard configuration options in the role, i.e. generated frontend/backend lists from external sources.
Vagrantfile
which can be used to test any distro / ansible version combination instead waiting for Travis to complain.