Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Sample MsgExt Search QuickStart To Python #1497

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mohammed-MSFT
Copy link
Contributor

No description provided.

@Pawank-MSFT Pawank-MSFT requested a review from Copilot December 30, 2024 11:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 28 changed files in this pull request and generated 1 comment.

Files not reviewed (13)
  • samples/msgext-search-quickstart/python/.gitignore: Language not supported
  • samples/msgext-search-quickstart/python/.vscode/extensions.json: Language not supported
  • samples/msgext-search-quickstart/python/.vscode/launch.json: Language not supported
  • samples/msgext-search-quickstart/python/.vscode/settings.json: Language not supported
  • samples/msgext-search-quickstart/python/.vscode/tasks.json: Language not supported
  • samples/msgext-search-quickstart/python/appManifest/manifest.json: Language not supported
  • samples/msgext-search-quickstart/python/assets/sample.json: Language not supported
  • samples/msgext-search-quickstart/python/env/.env.local: Language not supported
  • samples/msgext-search-quickstart/python/infra/azure.bicep: Language not supported
  • samples/msgext-search-quickstart/python/infra/azure.parameters.json: Language not supported
  • samples/msgext-search-quickstart/python/requirements.txt: Language not supported
  • samples/msgext-search-quickstart/python/bots/init.py: Evaluated as low risk
  • samples/msgext-search-quickstart/python/bots/botActivityHandler.py: Evaluated as low risk
Comments suppressed due to low confidence (2)

samples/msgext-search-quickstart/python/app.py:37

  • [nitpick] The error message is too generic. Consider changing it to 'An unexpected error occurred. Please try again later.'
await context.send_activity("The bot encountered an error or bug.")

samples/msgext-search-quickstart/python/app.py:39

  • [nitpick] The error message is too generic. Consider changing it to 'Please contact support if the issue persists.'
await context.send_activity("To continue to run this bot, please fix the bot source code.")

- python
extensions:
contentType: samples
createdDate: "26/12/2024 01:38:27 PM"
Copy link
Preview

Copilot AI Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date format should be in the format "YYYY-MM-DD".

Suggested change
createdDate: "26/12/2024 01:38:27 PM"
createdDate: "2024-12-26 01:38:27 PM"

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using this format 26/12/2024 01:38:27 PM in all samples in our repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant