Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Review] Adding back in the deprecation pipeline #2684

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jadahiya-MSFT
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

Summarize the changes, including the goals and reasons for this change. Be sure to call out any technical or behavior changes that reviewers should be aware of.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. <Change 1>
  2. <Change 2>

Validation

Validation performed:

  1. <Step 1>
  2. <Step 2>

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

<Yes/No>

End-to-end tests added:

<Yes/No>

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Related PRs:

Remove this section if n/a

Next/remaining steps:

List the next or remaining steps in implementing the overall feature in subsequent PRs (or is the feature 100% complete after this?).

Remove this section if n/a

  • Item 1
  • Item 2

Screenshots:

Remove this section if n/a

Before After
< image1 > < image2 >

@jadahiya-MSFT jadahiya-MSFT requested a review from a team as a code owner January 17, 2025 00:37
@AE-MS
Copy link
Contributor

AE-MS commented Jan 17, 2025

Is there a way this can be validated before it's committed?

command: custom
workingDir: $(PIPELINE.WORKSPACE)/microsoft-teams-library-js-pipeline/NPMFeed
verbose: false
customCommand: deprecate @microsoft/[email protected].* "Package no longer supported. Use at your own risk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecate @microsoft/[email protected].*

Can you say more about how this pipeline works? This looks like every time the pipeline runs, it deprecates all 3.0.* packages. Is that how it's supposed to work? Or is the person who runs the pipeline supposed to be able to specify what version they want to deprecate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was just meant to be a draft PR to see if the new pipeline would be added into ADO. Will be modifying this so that we can specify the version/versions we wish to deprecate as a Pipeline resource going forward.

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

command: custom
workingDir: $(PIPELINE.WORKSPACE)/microsoft-teams-library-js-pipeline/NPMFeed
verbose: false
customCommand: deprecate @microsoft/[email protected].* "Package no longer supported. Use at your own risk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like rather than needing to check in a PR each time you want to deprecate a version; it would make more sense to make the version a pipeline variable so we can edit it in ADO each time we run the pipeline.

Suggested change
customCommand: deprecate @microsoft/teams-js@3.0.* "Package no longer supported. Use at your own risk"
customCommand: deprecate @microsoft/teams-js@$(versionToDeprecate) "Package no longer supported. Use at your own risk"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup the plan was to make the version/versions plummed in as a pipeline resource instead of a single version. Only had it as the above since I was intending for this PR to actually just be a draft to see if it gets added to ADO correctly

@jadahiya-MSFT jadahiya-MSFT changed the title Adding back in the deprecation pipeline [Do Not Review] Adding back in the deprecation pipeline Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants