Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce closed forest via item placement and make compatible with ER #2349

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Jan 14, 2025

This is everything in #1531 except for the new setting that allows playing with the forest exit blocked but without the item restrictions. To summarize, this PR modifies closed forest to:

  • Prevent items that could be used to glitchlessly escape the forest without defeating Queen Gohma from being placed inside the forest area. (Glitched methods are unaffected.)
  • Force one slingshot per player to be placed inside the forest area (of any player) to significantly reduce the likelihood that some players get stuck in the forest area for a long time waiting for another player to find their slingshot.
  • Remove the incompatibility with special interior, hideout, overworld, warp song, and spawn ER (which would previously silently change the setting to Closed Deku). Instead, relevant entrance pools are split into a pool inside the forest and one outside, which are shuffled separately to prevent forest escapes.

@fenhl fenhl added Type: Enhancement New feature or request Component: Algorithm Search, Fill, Playthrough, etc Status: Needs Review Someone should be looking at it Component: Setting specific to setting(s) Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Jan 14, 2025
@flagrama
Copy link

  • Prevent items that could be used to glitchlessly escape the forest without defeating Queen Gohma from being placed inside the forest area. (Glitched methods are unaffected.)

This being on unconditionally is the only part I don't really like about this. I understand doing it for newbies as they are always confused by this, and not too many people use the setting otherwise so having a dedicated setting for it would be weird, but maybe there could be some plando flag to enable the old behaviour?

@fenhl
Copy link
Collaborator Author

fenhl commented Jan 14, 2025

I suppose adding the Require Gohma setting (the other half of #1531) as a plando-only setting could be a good compromise.

@r0bd0g
Copy link

r0bd0g commented Jan 15, 2025

"Prevent items that could be used to glitchlessly escape the forest without defeating Queen Gohma from being placed inside the forest area."
I don't think we should do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Algorithm Search, Fill, Playthrough, etc Component: Setting specific to setting(s) Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants