Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Kakariko Gate patch resulting in 2.2 GB patched.z64 rom #2352

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from
Open

Fix issue with Kakariko Gate patch resulting in 2.2 GB patched.z64 rom #2352

wants to merge 2 commits into from
+14 −4

Conversation

mzxrules
Copy link

First commit in a hot minute.

The Kakariko Gate speedup patch was being applied to the wrong rom address, creating a massively oversized patched rom file.

@cjohnson57 cjohnson57 added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Testing Probably should be tested Component: Patching Affects the patching of the ROM labels Jan 17, 2025
@mzxrules mzxrules mentioned this pull request Jan 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjohnson57 cjohnson57 cjohnson57 approved these changes

Assignees
No one assigned
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Component: Patching Affects the patching of the ROM Status: Needs Testing Probably should be tested Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzxrules @cjohnson57