-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement config package #142
Conversation
I would have re-implemented it with async and the old test suite (not perfect but it was doing the job). Synchronous API are not idiot but require a deeper refactor. And yes Generics is welcome |
I've added some test and the coverage is now 97% @fraxken WDYM by deeper refactor ? I'd like to implement both sync and async methods ( |
@PierreDemailly Some API has been designed to be lazy with async. Also having both make things a lot more complicated for me in term of how things are abstract. |
I would rename Config -> ConfigSync and save it into a separate files. And keep index to export. |
@allcontributors please add @PierreDemailly for code, docs, maintenance |
I've put up a pull request to add @PierreDemailly! 🎉 |
TODOs
I would appreciate a first review @fraxken