-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:set command sinter #107
Merged
AlexStocks
merged 23 commits into
OpenAtomFoundation:unstable
from
578223592:cmd_dev_sinter
Jan 22, 2024
Merged
feat:set command sinter #107
AlexStocks
merged 23 commits into
OpenAtomFoundation:unstable
from
578223592:cmd_dev_sinter
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero-heng
reviewed
Jan 8, 2024
AlexStocks
reviewed
Jan 18, 2024
AlexStocks
reviewed
Jan 18, 2024
AlexStocks
reviewed
Jan 20, 2024
AlexStocks
reviewed
Jan 20, 2024
AlexStocks
previously approved these changes
Jan 20, 2024
我看局部变量命名大多用的小驼峰,建议用lower_case这样的小写下划线,保持统一一下,不过不强求 |
AlexStocks
reviewed
Jan 21, 2024
AlexStocks
reviewed
Jan 21, 2024
感谢提醒,全部修改了。 @longfar-ncy @AlexStocks |
@578223592 有一个 mac 平台的 string ut 失败了,麻烦看下哈 |
done. |
hero-heng
approved these changes
Jan 22, 2024
AlexStocks
approved these changes
Jan 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30
sinter
cmd and unit testall set commands use backend rather than cache(conMap)