Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:set command sinter #107

Merged
merged 23 commits into from
Jan 22, 2024

Conversation

578223592
Copy link
Collaborator

@578223592 578223592 commented Jan 4, 2024

#30

  1. sinter cmd and unit test

  2. all set commands use backend rather than cache(conMap)

@github-actions github-actions bot added the ✏️ Feature New feature or request label Jan 4, 2024
@578223592 578223592 requested a review from hero-heng January 7, 2024 09:01
@578223592 578223592 marked this pull request as ready for review January 7, 2024 09:02
src/cmd_set.cc Outdated Show resolved Hide resolved
src/cmd_set.cc Outdated Show resolved Hide resolved
src/cmd_set.cc Outdated Show resolved Hide resolved
AlexStocks
AlexStocks previously approved these changes Jan 20, 2024
@longfar-ncy
Copy link
Collaborator

longfar-ncy commented Jan 20, 2024

我看局部变量命名大多用的小驼峰,建议用lower_case这样的小写下划线,保持统一一下,不过不强求

@AlexStocks AlexStocks mentioned this pull request Jan 21, 2024
2 tasks
src/cmd_set.cc Outdated Show resolved Hide resolved
src/cmd_set.cc Outdated Show resolved Hide resolved
@578223592
Copy link
Collaborator Author

我看局部变量命名大多用的小驼峰,建议用lower_case这样的小写下划线,保持统一一下,不过不强求

感谢提醒,全部修改了。 @longfar-ncy @AlexStocks

@AlexStocks
Copy link
Contributor

@578223592 有一个 mac 平台的 string ut 失败了,麻烦看下哈

@578223592
Copy link
Collaborator Author

@578223592 有一个 mac 平台的 string ut 失败了,麻烦看下哈

done.
解决方案就是再跑一遍,报错测试错在string test那块,那块和set没关系的,应该不会有问题,然后再跑一遍就过了

@AlexStocks AlexStocks merged commit 8049864 into OpenAtomFoundation:unstable Jan 22, 2024
5 checks passed
@578223592 578223592 deleted the cmd_dev_sinter branch January 22, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1.0 core ✏️ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants