Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reimplement cmds flushdb & flushall #205

Merged
merged 13 commits into from
May 6, 2024

Conversation

super-Pan66
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ✏️ Feature New feature or request label Mar 13, 2024
AlexStocks
AlexStocks previously approved these changes Mar 18, 2024
@AlexStocks AlexStocks requested a review from panlei-coder March 18, 2024 10:18
src/cmd_admin.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@panlei-coder panlei-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要考虑加测试么

@AlexStocks
Copy link
Contributor

这个要考虑加测试么

他代码是借鉴了 pika,pika 没测试,不好加了。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Should we consider testing this?

His code is borrowed from pika. Pika has not been tested, so it is difficult to add it.

src/cmd_admin.cc Outdated Show resolved Hide resolved
AlexStocks
AlexStocks previously approved these changes Mar 30, 2024
@AlexStocks
Copy link
Contributor

有文件冲突,请处理下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


There is a file conflict, please resolve it

@AlexStocks
Copy link
Contributor

ci 失败,提示 “/home/runner/work/pikiwidb/pikiwidb/src/cmd_admin.cc had clang-format style issues”

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


ci failed, prompting "/home/runner/work/pikiwidb/pikiwidb/src/cmd_admin.cc had clang-format style issues"

panlei-coder
panlei-coder previously approved these changes May 6, 2024
AlexStocks
AlexStocks previously approved these changes May 6, 2024
@AlexStocks AlexStocks merged commit d0f77f6 into OpenAtomFoundation:unstable May 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants