feat: support cmd persist
#214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happy-v587
commented
Mar 17, 2024
src/cmd_keys.cc
Outdated
| if (res != -1) { | ||
| client->AppendInteger(res); | ||
| if (res > -1) { | ||
| client->AppendInteger(res == 0 ? 0 : 1); |
There was a problem hiding this comment.
res有可能大于1，但redis不会出现。如果我们返回值大于1，会导致go-redis处理结果不正确。
返回值可能大于1的原因是因为我们支持同名key存储到不同datatype导致。
There was a problem hiding this comment.
目前Pikiwidb是不兼容的，因为允许同名key的原因，但是最近群里在讨论如何静止同名key存在，到时候就不会有这个问题了。
因此个人建议：1.增加注释，在相关pr合入后方便理解这块的代码。2.直接返回，在相关pr合并后应该就没有兼容性的问题了。
There was a problem hiding this comment.
多谢评审。既然已经开始讨论同名key禁止问题的处理，那么就保持现状吧，我将改动回滚。因为persist也存在这个问题，我将其保持一致。
issue: OpenAtomFoundation#30 Signed-off-by: HappyUncle <[email protected]>
happy-v587
force-pushed
the
feat-persist
branch
from
fe56798 to
7971227
Compare
578223592
approved these changes
Mar 17, 2024
AlexStocks
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #30