Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Key cmd add Type Expire Ttl #215

Merged
merged 13 commits into from
Apr 11, 2024

Conversation

clearocean621
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ✏️ Feature New feature or request label Mar 17, 2024
AlexStocks
AlexStocks previously approved these changes Mar 18, 2024
@AlexStocks
Copy link
Contributor

代码风格有问题

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


There is a problem with the coding style

AlexStocks
AlexStocks previously approved these changes Mar 28, 2024
@AlexStocks
Copy link
Contributor

image

@clearocean621 处理下这个 CI 错误哈

@clearocean621
Copy link
Contributor Author

image

@clearocean621 处理下这个 CI 错误哈

好的雨哥

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


![image](https://private-user-images.githubusercontent.com/7959374/317673440-82affbf6-5f54-4cba-9ea6-19db06bdf616.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRo dWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE2MjAyMTMsIm5iZiI6MTcxMTYxOTkxMywicGF0aCI6Ii83OTU5Mzc0LzMxNzY3M zQ0MC04MmFmZmJmNi01ZjU0LTRjYmEtOWVhNi0xOWRiMDZiZGY2MTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUU s0WkElMkYyMDI0MDMyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMjhUMDk1ODMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OThmZm QzNDRiZDM2NWU3MjMyMmFhZTlhYmJlZjQ0ZGQ3NGQwMzNhMzdjYWM2ZTJiZjUxYjZkODAxMDNlYWYxZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZX BvX2lkPTAifQ._wwd-O4OO21van0hTyFu-it8W_BOKW4LLdcjMrjupro)

@clearocean621 handle this CI error haha

Okay Brother Yu

Copy link
Collaborator

@lqxhub lqxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码没问题, 我觉得测试用例最好再丰富一点, 比如, type 命令 找一个不存在的key,

expire 1秒, 然后等2秒再去查一下 这个key是否还能查到, 设置一个超过 uint32 的时间

ttl 也是, 查一下 不存在的key, 超过uint32 的key

总之就是最好能多测试一些边界情况, 也可以参考一下redis的 tcl 测试用例, 他们的测试用例还是比较丰富的

@clearocean621
Copy link
Contributor Author

代码没问题, 我觉得测试用例最好再丰富一点, 比如, type 命令 找一个不存在的key,

expire 1秒, 然后等2秒再去查一下 这个key是否还能查到, 设置一个超过 uint32 的时间

ttl 也是, 查一下 不存在的key, 超过uint32 的key

总之就是最好能多测试一些边界情况, 也可以参考一下redis的 tcl 测试用例, 他们的测试用例还是比较丰富的

好的QX哥,我再补充一些测试用例!

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


There is no problem with the code. I think it is better to enrich the test cases. For example, the type command finds a key that does not exist.

expire 1 second, then wait 2 seconds before checking whether the key can still be found, and set a time exceeding uint32

ttl is the same, check for non-existent keys and keys exceeding uint32

In short, it is best to test more edge cases. You can also refer to redis's tcl test cases. Their test cases are quite rich.

Okay Brother QX, I will add some test cases!

@Mixficsol Mixficsol merged commit 57248c3 into OpenAtomFoundation:unstable Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants