-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Key cmd add Type Expire Ttl #215
feat: Key cmd add Type Expire Ttl #215
Conversation
代码风格有问题 |
There is a problem with the coding style |
Merge branch 'unstable' of https://github.com/clearocean621/pikiwidb into unstable
@clearocean621 处理下这个 CI 错误哈 |
好的雨哥 |
Okay Brother Yu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码没问题, 我觉得测试用例最好再丰富一点, 比如, type
命令 找一个不存在的key,
expire
1秒, 然后等2秒再去查一下 这个key是否还能查到, 设置一个超过 uint32 的时间
ttl
也是, 查一下 不存在的key, 超过uint32 的key
总之就是最好能多测试一些边界情况, 也可以参考一下redis的 tcl 测试用例, 他们的测试用例还是比较丰富的
好的QX哥,我再补充一些测试用例! |
Okay Brother QX, I will add some test cases! |
No description provided.