add create empty blocks config for single consensus #432
Conversation
| if m.ctx.EngCtx.EngCfg.DisableEmyptBlocks && !m.ctx.State.HasUnconfirmTx() { | ||
| consensusStatus, err := m.ctx.Consensus.GetConsensusStatus() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
对于挖矿条件的判断，实现在m.mining(ctx)中可读性会不会更好一些？
There was a problem hiding this comment.
m.mining(ctx) 已经开始挖矿了，所以我放到外面了。
There was a problem hiding this comment.
主要是有个疑问：
mining()实现的第一部分为"共识挖矿前处理"的定义是什么？- 打包区块前的判断逻辑，根据什么判断要放在
mining()的函数头部 还是 函数调用前？
There was a problem hiding this comment.
空块判断不太算 ProcessBeforeMiner 的内容
节点若为矿工，首先通过Consensus模块ProcessBeforeMiner接口更新自己共识内存状态，准备开始生产区块。
5. 共识算法 — XuperChain 官方文档 文档
There was a problem hiding this comment.
我有一点建议是：
- 上层调用的时候，在确认是挖矿状态后，就只负责调用挖矿函数。
- 至于挖矿的前置处理、特殊判断（比如空块判断）等，可以在挖矿过程中，分阶段处理。
更具体的，在这个 case，我可能会建议实现在m.packBlock
相当于打包过程中，对区块大小的上限和下限分别进行判断处理。
godeamon
force-pushed
the
empty_block_single
branch
from
6e89241 to
7f55c97
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 43.86% 43.80% -0.07%
==========================================
Files 149 149
Lines 13358 13359 +1
==========================================
- Hits 5860 5852 -8
- Misses 6313 6321 +8
- Partials 1185 1186 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
No description provided.