Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Adding TagRule frontend (#1998) #2213

Open
wants to merge 29 commits into
base: release/current
Choose a base branch
from

Conversation

heditar
Copy link
Contributor

@heditar heditar commented Jan 15, 2025

Proposed changes

  • Add the new page to manage TagRules in Settings-> Customization
  • Add the pop up at the scenario/update to ask the user if he wants to apply the default assets group if a rules is detected. This part also required two new api in the backend
  • Refactored the existing code (after discussing it with PM) to only add defaults asset groups and not remove any group when a scenario/simulation is updated
  • Added the creation of tag and tagrule if it doesn't exist at the start of the server

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • [] I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • [] For bug fix -> I implemented a test that covers the bug

@heditar heditar added the filigran team use to identify PR from the Filigran team label Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes missing coverage. Please review.

Project coverage is 34.76%. Comparing base (b64044e) to head (6667a81).

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/rest/inject/InjectApi.java 0.00% 8 Missing and 2 partials ⚠️
.../io/openbas/rest/exception/ForbiddenException.java 50.00% 2 Missing ⚠️
.../io/openbas/rest/inject/service/InjectService.java 80.00% 2 Missing ⚠️
...c/main/java/io/openbas/service/TagRuleService.java 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2213      +/-   ##
=====================================================
+ Coverage              34.67%   34.76%   +0.08%     
- Complexity              1593     1607      +14     
=====================================================
  Files                    586      588       +2     
  Lines                  17991    18034      +43     
  Branches                1169     1177       +8     
=====================================================
+ Hits                    6239     6270      +31     
- Misses                 11449    11458       +9     
- Partials                 303      306       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guillaumejparis guillaumejparis changed the title [frontend][backend] Adding Tagule frontend Issue/1998 [frontend/backend] Adding Tagule frontend (#1998) Jan 20, 2025
@savacano28 savacano28 requested review from savacano28 and removed request for savacano28 January 21, 2025 10:25
@Dimfacion Dimfacion self-requested a review January 21, 2025 13:47
@Dimfacion
Copy link
Member

image
There is a translation missing

@heditar
Copy link
Contributor Author

heditar commented Jan 22, 2025

image There is a translation missing

fixed

@antoinemzs antoinemzs changed the title [frontend/backend] Adding Tagule frontend (#1998) [frontend/backend] Adding TagRule frontend (#1998) Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define and apply default assets for OCTI generated simulation
3 participants