Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Implement injectExpectations per agent level #2228

Draft
wants to merge 40 commits into
base: release/current
Choose a base branch
from

Conversation

savacano28
Copy link
Contributor

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jan 16, 2025
@savacano28 savacano28 changed the base branch from master to release/current January 16, 2025 12:59
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 6.45161% with 87 lines in your changes missing coverage. Please review.

Project coverage is 33.11%. Comparing base (351f0fb) to head (28a8b58).
Report is 5 commits behind head on release/current.

Files with missing lines Patch % Lines
...a/io/openbas/service/InjectExpectationService.java 0.00% 46 Missing and 2 partials ⚠️
.../service/ExpectationsExpirationManagerService.java 0.00% 17 Missing ⚠️
...va/io/openbas/rest/expectation/ExpectationApi.java 0.00% 17 Missing ⚠️
...ava/io/openbas/service/InjectExpectationUtils.java 0.00% 3 Missing ⚠️
...nbas/injectors/openbas/OpenBASImplantExecutor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2228      +/-   ##
=====================================================
+ Coverage              32.90%   33.11%   +0.20%     
- Complexity              1512     1526      +14     
=====================================================
  Files                    582      583       +1     
  Lines                  17937    18177     +240     
  Branches                1154     1188      +34     
=====================================================
+ Hits                    5903     6019     +116     
- Misses                 11770    11882     +112     
- Partials                 264      276      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the issue/2217 branch 4 times, most recently from a3a88bc to 6058db5 Compare January 23, 2025 10:41
@savacano28 savacano28 linked an issue Jan 23, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants