Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Enable the ordering in Observables / nested objects panel (#9280) #9527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

Proposed changes

  • Changes to orderBy and orderMode to sort by type when clicked.

Related issues

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX added the filigran team use to identify PR from the Filigran team label Jan 8, 2025
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.12%. Comparing base (b293e2e) to head (327ad0b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9527   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files         630      630           
  Lines       60083    60083           
  Branches     6694     6696    +2     
=======================================
+ Hits        39127    39128    +1     
+ Misses      20956    20955    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review January 8, 2025 12:54
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the title [frontend] Enable the order function in Observables / nested objects panel (#9280) [frontend] Enable the ordering in Observables / nested objects panel (#9280) Jan 8, 2025
@JeremyCloarec JeremyCloarec self-requested a review January 10, 2025 11:20
@JeremyCloarec
Copy link
Contributor

Right now, if a search term is used, we still can't order by Types.
I think it could be great if the behavior was the same as in the Data/Entities page for exemple: when a search inputted, the sorting is reinitialized, but we can still sort by a selected column afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants