Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix auth0 provider for env variable (#9554) #9557

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jan 10, 2025

Proposed changes

  • Fix env var for auth0

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 10, 2025
@@ -253,8 +253,8 @@ export const logApp = {
if (appLogTransports.length > 0 && appLogger.isLevelEnabled(level)) {
const data = addBasicMetaInformation(LOG_APP, error, { ...meta, source: 'backend' });
// Prevent meta information to be too massive.
const limitedData = limitMetaErrorComplexity(data);
appLogger.log(level, message, limitedData);
// const limitedData = limitMetaErrorComplexity(data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this ? if necessary to keep, please add a comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen with Angelique, its a problem i need to fix on my side

@labo-flg
Copy link
Member

Ci build failing for a failed test @richard-julien

× Logger test suite > Log object is correctly limited
→ expected 56 to not deeply equal 56

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.15%. Comparing base (7180d27) to head (6e2dc49).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...i-platform/opencti-graphql/src/config/providers.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9557      +/-   ##
==========================================
+ Coverage   65.13%   65.15%   +0.01%     
==========================================
  Files         630      630              
  Lines       60147    60159      +12     
  Branches     6703     6708       +5     
==========================================
+ Hits        39179    39194      +15     
+ Misses      20968    20965       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richard-julien richard-julien merged commit 335766c into master Jan 10, 2025
7 checks passed
@richard-julien richard-julien deleted the issue/9554 branch January 10, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth0 issue when using environment variable for clientID
3 participants