Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTF - obj2glb - Set extensionsUsed in all cases to be consistent with the GLTF standard #1746

Merged
merged 1 commit into from
Feb 9, 2024
Merged

GLTF - obj2glb - Set extensionsUsed in all cases to be consistent with the GLTF standard #1746

merged 1 commit into from
Feb 9, 2024

Conversation

kielnino
Copy link
Contributor

@kielnino kielnino commented Feb 9, 2024 •
edited
Loading

As the GLTF Definition states

All extensions used in a model are listed as strings in the top-level extensionsUsed array.

So extensionsUsed should be set in all cases. With this change extensionsUsed is set even if rtc is (None, None) (which is the default).

In our use case we didn't had georeferences so rtc was not set and the created glb file couldn't be loaded with the three.js GLTFLoader because extensionsUsed was not set.

@pierotofy
Copy link
Member

Looks great, thanks @kielnino !

@pierotofy pierotofy merged commit fc9c948 into OpenDroneMap:master Feb 9, 2024
2 checks passed
@kielnino kielnino deleted the set-extensionsused branch February 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kielnino @pierotofy