Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The nodes optional attributes to LigandNetworks is unclear / unexplained #360

Closed
IAlibay opened this issue Oct 11, 2024 · 0 comments · Fixed by #390
Closed

The nodes optional attributes to LigandNetworks is unclear / unexplained #360

IAlibay opened this issue Oct 11, 2024 · 0 comments · Fixed by #390
Assignees
@atravitz
Labels
docs-developer good first issue Good for newcomers
Milestone
Release 1.2

Comments

@IAlibay
Copy link
Member

IAlibay commented Oct 11, 2024

From a developer or user perspective, it's unclear what is the intent of the nodes kwarg.

My personal understanding is that it's to add nodes that aren't connected (i.e. if you had absolute calculations or similar). Making the intent clearer would be really helpful.
@dotsdl dotsdl added this to the Release 1.2 milestone Oct 15, 2024
@dotsdl dotsdl moved this to Sprint - Available in gufe : advancement sprints Oct 15, 2024
@atravitz atravitz mentioned this issue Nov 7, 2024
Merged
@atravitz atravitz linked a pull request Nov 7, 2024 that will close this issue
adding to LigandNetwork docstring #390
Merged
@github-project-automation github-project-automation bot moved this from Sprint - Available to Done in gufe : advancement sprints Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atravitz atravitz

Labels
docs-developer good first issue Good for newcomers
Projects
gufe : advancement sprints
Archived in project
Milestone
Release 1.2
Development

Successfully merging a pull request may close this issue.

adding to LigandNetwork docstring OpenFreeEnergy/gufe
3 participants
@dotsdl @IAlibay @atravitz