Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding to LigandNetwork docstring #390

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Nov 7, 2024

addresses #360.

hopefully this is more clear (and also correct).

@atravitz atravitz requested review from IAlibay and dotsdl November 7, 2024 23:46
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (43d86f9) to head (a952925).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          36       36           
  Lines        2075     2075           
=======================================
  Hits         2047     2047           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks!

gufe/ligandnetwork.py Show resolved Hide resolved
@atravitz atravitz merged commit 5cdb748 into main Nov 8, 2024
10 checks passed
@atravitz atravitz deleted the 360-the-nodes-optional-attributes-to-ligandnetworks-is-unclear-unexplained branch November 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The nodes optional attributes to LigandNetworks is unclear / unexplained
3 participants